Skip to content

Commit

Permalink
fix links and titles to cards
Browse files Browse the repository at this point in the history
  • Loading branch information
snide committed Oct 14, 2021
1 parent 03e8113 commit 171f889
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export const ElasticAgentCard: FunctionComponent<ElasticAgentCardProps> = ({
description={
<EuiTextColor color="default">
{i18n.translate('kibana-react.noDataPage.elasticAgentCard.noPermission.description', {
defaultMessage: `This application is not yet set up. If you’d like to use it please contact your Kibana administrator to add this integration.`,
defaultMessage: `This integration is not yet enabled. You do not have the permissions level to turn it on.`,
})}
</EuiTextColor>
}
Expand All @@ -80,7 +80,7 @@ export const ElasticAgentCard: FunctionComponent<ElasticAgentCardProps> = ({
paddingSize="l"
image={image}
href={href ?? addBasePath(`/app/integrations/browse${hasCategory}`)}
title={title || defaultCTAtitle}
title=""
description={i18n.translate('kibana-react.noDataPage.elasticAgentCard.description', {
defaultMessage: `Use Elastic Agent for a simple, unified way to collect data from your machines.`,
})}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ export function RumHome() {
actions: {
beats: {
title: i18n.translate('xpack.apm.ux.overview.beatsCard.title', {
defaultMessage: 'Add RUM data',
defaultMessage: 'Add the APM integration',
}),
description: i18n.translate(
'xpack.apm.ux.overview.beatsCard.description',
{
defaultMessage:
'Use the RUM (JS) agent to collect user experience data.',
'Enable RUM with the APM agent to collect user experience data.',
}
),
href: core.http.basePath.prepend(`/app/home#/tutorial/apm`),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export function getNoDataConfig({
actions: {
beats: {
title: i18n.translate('xpack.apm.noDataConfig.beatsCard.title', {
defaultMessage: 'Add data with APM agents',
defaultMessage: 'Add the APM integration',
}),
description: i18n.translate(
'xpack.apm.noDataConfig.beatsCard.description',
Expand Down
6 changes: 3 additions & 3 deletions x-pack/plugins/infra/public/pages/logs/page_template.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ export const LogsPageTemplate: React.FC<LogsPageTemplateProps> = ({
actions: {
beats: {
title: i18n.translate('xpack.infra.logs.noDataConfig.beatsCard.title', {
defaultMessage: 'Add logs with Beats',
defaultMessage: 'Add a logging integration',
}),
description: i18n.translate('xpack.infra.logs.noDataConfig.beatsCard.description', {
defaultMessage:
'Use Beats to send logs to Elasticsearch. We make it easy with modules for many popular systems and apps.',
'Use the Elastic Agent or Beats to send logs to Elasticsearch. We make it easy with integrations for many popular systems and apps.',
}),
href: basePath + `/app/home#/tutorial_directory/logging`,
href: basePath + `/app/integrations/browse`,
},
},
docsLink: docLinks.links.observability.guide,
Expand Down
5 changes: 4 additions & 1 deletion x-pack/plugins/observability/public/utils/no_data_config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,14 @@ export function getNoDataConfig({
}),
actions: {
beats: {
title: i18n.translate('xpack.observability.noDataConfig.beatsCard.title', {
defaultMessage: 'Add an integration',
}),
description: i18n.translate('xpack.observability.noDataConfig.beatsCard.description', {
defaultMessage:
'Use Beats and APM agents to send observability data to Elasticsearch. We make it easy with support for many popular systems, apps, and languages.',
}),
href: basePath.prepend(`/app/home#/tutorial_directory/logging`),
href: basePath.prepend(`/app/integrations`),
},
},
docsLink,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,12 @@ const OverviewEmptyComponent: React.FC = () => {
const agentAction: NoDataPageActionsProps = {
elasticAgent: {
category: 'security',
title: i18n.translate('xpack.securitySolution.pages.emptyPage.beatsCard.title', {
defaultMessage: 'Add a Security integration',
}),
description: i18n.translate('xpack.securitySolution.pages.emptyPage.beatsCard.description', {
defaultMessage:
'Use Elastic Agent to collect security events and protect your endpoints from threats. Manage your agents in Fleet and add integrations with a single click.',
'Use Elastic Agent to collect security events and protect your endpoints from threats.',
}),
},
};
Expand Down

0 comments on commit 171f889

Please sign in to comment.