Skip to content

Commit

Permalink
[config] Add path.conf, path.data
Browse files Browse the repository at this point in the history
  • Loading branch information
jbudz committed Jun 16, 2016
1 parent 5b19534 commit 16e8975
Show file tree
Hide file tree
Showing 7 changed files with 58 additions and 21 deletions.
Empty file added installedPlugins/.data/.empty
Empty file.
3 changes: 2 additions & 1 deletion src/cli/serve/serve.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { statSync } from 'fs';
import { isWorker } from 'cluster';
import { resolve } from 'path';
import { fromRoot } from '../../utils';
import { getConfig } from '../../server/path';
import readYamlConfig from './read_yaml_config';

let canCluster;
Expand Down Expand Up @@ -77,7 +78,7 @@ module.exports = function (program) {
'Path to the config file, can be changed with the CONFIG_PATH environment variable as well. ' +
'Use mulitple --config args to include multiple config files.',
configPathCollector,
[ process.env.CONFIG_PATH || fromRoot('config/kibana.yml') ]
[ getConfig() ]
)
.option('-p, --port <port>', 'The port to bind to', parseInt)
.option('-q, --quiet', 'Prevent all logging except errors')
Expand Down
21 changes: 2 additions & 19 deletions src/cli_plugin/install/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import fs from 'fs';
import install from './install';
import Logger from '../lib/logger';
import pkg from '../../utils/package_json';
import { getConfig } from '../../server/path';
import { parse, parseMilliseconds } from './settings';
import { find } from 'lodash';

Expand All @@ -20,24 +21,6 @@ function processCommand(command, options) {
install(settings, logger);
}

function getDefaultConfigPath() {
const paths = [
fromRoot('config/kibana.yml'),
'/etc/kibana/kibana.yml'
];

const availablePath = find(paths, configPath => {
try {
fs.accessSync(configPath, fs.R_OK);
return true;
} catch (e) {
//Check the next path
}
});

return availablePath || paths[0];
}

export default function pluginInstall(program) {
program
.command('install <plugin/url>')
Expand All @@ -46,7 +29,7 @@ export default function pluginInstall(program) {
.option(
'-c, --config <path>',
'path to the config file',
getDefaultConfigPath()
getConfig()
)
.option(
'-t, --timeout <duration>',
Expand Down
3 changes: 2 additions & 1 deletion src/cli_plugin/remove/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { fromRoot } from '../../utils';
import remove from './remove';
import Logger from '../lib/logger';
import { parse } from './settings';
import { getConfig } from '../../server/path';

function processCommand(command, options) {
let settings;
Expand All @@ -25,7 +26,7 @@ export default function pluginRemove(program) {
.option(
'-c, --config <path>',
'path to the config file',
fromRoot('config/kibana.yml')
getConfig()
)
.option(
'-d, --plugin-dir <path>',
Expand Down
5 changes: 5 additions & 0 deletions src/server/config/schema.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { randomBytes } from 'crypto';
import os from 'os';

import { fromRoot } from '../../utils';
import { getData } from '../path';

module.exports = () => Joi.object({
pkg: Joi.object({
Expand Down Expand Up @@ -95,6 +96,10 @@ module.exports = () => Joi.object({
initialize: Joi.boolean().default(true)
}).default(),

path: Joi.object({
data: Joi.string().default(getData())
}).default(),

optimize: Joi.object({
enabled: Joi.boolean().default(true),
bundleFilter: Joi.string().default('!tests'),
Expand Down
15 changes: 15 additions & 0 deletions src/server/path/__tests__/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import expect from 'expect.js';
import path from '../';
import { accessSync, R_OK} from 'fs';

describe('Default path finder', function () {
it('should find a kibana.yml', () => {
const configPath = path.getConfig();
expect(() => accessSync(configPath, R_OK)).to.not.throwError();
});

it('should find a data directory', () => {
const dataPath = path.getData();
expect(() => accessSync(dataPath, R_OK)).to.not.throwError();
});
});
32 changes: 32 additions & 0 deletions src/server/path/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
import { accessSync, R_OK} from 'fs';
import { find } from 'lodash';
import { fromRoot } from '../../utils';

const CONFIG_PATHS = [
process.env.CONFIG_PATH,
fromRoot('config/kibana.yml'),
'/etc/kibana/kibana.yml'
].filter(Boolean);

const DATA_PATHS = [
process.env.DATA_PATH,
fromRoot('installedPlugins/.data'),
'/var/lib/kibana'
].filter(Boolean);

function findFile(paths) {
const availablePath = find(paths, configPath => {
try {
accessSync(configPath, R_OK);
return true;
} catch (e) {
//Check the next path
}
});
return availablePath || paths[0];
}

export default {
getConfig: () => findFile(CONFIG_PATHS),
getData: () => findFile(DATA_PATHS)
};

0 comments on commit 16e8975

Please sign in to comment.