add copy to account for behaviour of temp dashboard link with panel c…

…hanges
elastic · Nov 18, 2024 · 11cf71f · 11cf71f
1 parent c055b30
commit 11cf71f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/plugins/dashboard/public/dashboard_app/_dashboard_app_strings.ts b/src/plugins/dashboard/public/dashboard_app/_dashboard_app_strings.ts
@@ -142,9 +142,9 @@ export const shareModalStrings = {
   getDraftSharePanelChangesWarning: () =>
     i18n.translate('dashboard.snapshotShare.panelChangesWarning', {
       defaultMessage:
-        'One or more panels on this dashboard have changed. Before generating a link, save the dashboard.',
+        'You are about to share a dashboard with unsaved changes, and the link may not work properly. Save the dashboard first to create a permanent link.',
     }),
-  getEmbedShareWarning: () =>
+  getEmbedSharePanelChangesWarning: () =>
     i18n.translate('dashboard.embedShare.draftWarning', {
       defaultMessage:
         'You are about to create an embedded dashboard with unsaved changes, and the embed code may not work properly. Save the dashboard first to create a permanent embedded dashboard.',

diff --git a/src/plugins/dashboard/public/dashboard_app/top_nav/share/show_share_modal.tsx b/src/plugins/dashboard/public/dashboard_app/top_nav/share/show_share_modal.tsx
@@ -241,7 +241,9 @@ export function ShowShareModal({
                 />
               }
             >
-              {shareModalStrings.getEmbedShareWarning()}
+              {Boolean(unsavedDashboardState?.panels)
+                ? shareModalStrings.getEmbedSharePanelChangesWarning()
+                : shareModalStrings.getDraftShareWarning()}
             </EuiCallOut>
           ),
         },