move condition to component

elastic · Oct 23, 2023 · 0fde45f · 0fde45f
1 parent 74afc5d
commit 0fde45f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/packages/shared-ux/chrome/navigation/src/ui/components/navigation_group.tsx b/packages/shared-ux/chrome/navigation/src/ui/components/navigation_group.tsx
@@ -85,6 +85,8 @@ function NavigationGroupInternalComp<
       return null;
     }
 
+    if (navNodeWithChildren.sideNavStatus === 'hidden') return null;
+
     if (unstyled) {
       // No UI for unstyled groups
       return children;

diff --git a/packages/shared-ux/chrome/navigation/src/ui/default_navigation.tsx b/packages/shared-ux/chrome/navigation/src/ui/default_navigation.tsx
@@ -194,7 +194,6 @@ export const DefaultNavigation: FC<ProjectNavigationDefinition & Props> = ({
         }
 
         if (isGroupDefinition(navNode)) {
-          if (navNode.sideNavStatus === 'hidden') return null;
           return (
             <Navigation.Group {...navNode} key={navNode.id}>
               {/* Recursively build the tree */}