[RAM] Type safety for RegistryRuleType (#164516)

## Summary

RegisterRuleType was not representing its definition correctly and the
type was not safe. So updated the code/type to avoid missing attribute
and functionality. Now summary alert is back
  

![image](https://github.com/elastic/kibana/assets/189600/95cb786a-7ab9-4d40-a65c-ecbe59a0fbd3)


### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

x-pack/plugins/alerting/server/authorization/alerting_authorization.ts

@@ -71,8 +71,6 @@ interface HasPrivileges {
 type AuthorizedConsumers = Record<string, HasPrivileges>;
 export interface RegistryAlertTypeWithAuth extends RegistryRuleType {
   authorizedConsumers: AuthorizedConsumers;
-  hasAlertsMappings?: boolean;
-  hasFieldsForAAD?: boolean;
 }
 
 type IsAuthorizedAtProducerLevel = boolean;
@@ -371,7 +369,7 @@ export class AlertingAuthorization {
       const ruleTypesWithAuthorization = Array.from(
         this.augmentWithAuthorizedConsumers(ruleTypes, {})
       );
-      const ruleTypesAuthorized: Map<string, RegistryRuleType> = new Map();
+      const ruleTypesAuthorized: Map<string, RegistryAlertTypeWithAuth> = new Map();
       // map from privilege to ruleType which we can refer back to when analyzing the result
       // of checkPrivileges
       const privilegeToRuleType = new Map<
@@ -386,9 +384,7 @@ export class AlertingAuthorization {
           const ruleTypeAuth = ruleTypesWithAuthorization.find((rtwa) => rtwa.id === ruleTypeId);
           if (ruleTypeAuth) {
             if (!ruleTypesAuthorized.has(ruleTypeId)) {
-              const { authorizedConsumers, hasAlertsMappings, hasFieldsForAAD, ...ruleType } =
-                ruleTypeAuth;
-              ruleTypesAuthorized.set(ruleTypeId, ruleType);
+              ruleTypesAuthorized.set(ruleTypeId, ruleTypeAuth);
             }
             for (const operation of operations) {
               privilegeToRuleType.set(

x-pack/plugins/alerting/server/authorization/alerting_authorization_kuery.test.ts

@@ -32,6 +32,8 @@ describe('asKqlFiltersByRuleTypeAndConsumer', () => {
               myApp: { read: true, all: true },
             },
             enabledInLicense: true,
+            hasAlertsMappings: false,
+            hasFieldsForAAD: false,
           },
         ]),
         {
@@ -67,6 +69,8 @@ describe('asKqlFiltersByRuleTypeAndConsumer', () => {
               myOtherApp: { read: true, all: true },
             },
             enabledInLicense: true,
+            hasAlertsMappings: false,
+            hasFieldsForAAD: false,
           },
         ]),
         {
@@ -105,6 +109,8 @@ describe('asKqlFiltersByRuleTypeAndConsumer', () => {
               myAppWithSubFeature: { read: true, all: true },
             },
             enabledInLicense: true,
+            hasAlertsMappings: false,
+            hasFieldsForAAD: false,
           },
           {
             actionGroups: [],
@@ -122,6 +128,8 @@ describe('asKqlFiltersByRuleTypeAndConsumer', () => {
               myAppWithSubFeature: { read: true, all: true },
             },
             enabledInLicense: true,
+            hasAlertsMappings: false,
+            hasFieldsForAAD: false,
           },
           {
             actionGroups: [],
@@ -139,6 +147,8 @@ describe('asKqlFiltersByRuleTypeAndConsumer', () => {
               myAppWithSubFeature: { read: true, all: true },
             },
             enabledInLicense: true,
+            hasAlertsMappings: false,
+            hasFieldsForAAD: false,
           },
         ]),
         {
@@ -177,6 +187,8 @@ describe('asKqlFiltersByRuleTypeAndConsumer', () => {
               myAppWithSubFeature: { read: true, all: true },
             },
             enabledInLicense: true,
+            hasAlertsMappings: false,
+            hasFieldsForAAD: false,
           },
           {
             actionGroups: [],
@@ -194,6 +206,8 @@ describe('asKqlFiltersByRuleTypeAndConsumer', () => {
               myAppWithSubFeature: { read: true, all: true },
             },
             enabledInLicense: true,
+            hasAlertsMappings: false,
+            hasFieldsForAAD: false,
           },
         ]),
         {
@@ -233,6 +247,8 @@ describe('asKqlFiltersByRuleTypeAndConsumer', () => {
               myAppWithSubFeature: { read: true, all: true },
             },
             enabledInLicense: true,
+            hasAlertsMappings: false,
+            hasFieldsForAAD: false,
           },
           {
             actionGroups: [],
@@ -250,6 +266,8 @@ describe('asKqlFiltersByRuleTypeAndConsumer', () => {
               myAppWithSubFeature: { read: true, all: true },
             },
             enabledInLicense: true,
+            hasAlertsMappings: false,
+            hasFieldsForAAD: false,
           },
         ]),
         {
@@ -283,6 +301,8 @@ describe('asKqlFiltersByRuleTypeAndConsumer', () => {
           isExportable: true,
           authorizedConsumers: {},
           enabledInLicense: true,
+          hasAlertsMappings: false,
+          hasFieldsForAAD: false,
         },
       ]),
       {
@@ -317,6 +337,8 @@ describe('asEsDslFiltersByRuleTypeAndConsumer', () => {
               myApp: { read: true, all: true },
             },
             enabledInLicense: true,
+            hasAlertsMappings: false,
+            hasFieldsForAAD: false,
           },
         ]),
         {
@@ -379,6 +401,8 @@ describe('asEsDslFiltersByRuleTypeAndConsumer', () => {
               myOtherApp: { read: true, all: true },
             },
             enabledInLicense: true,
+            hasAlertsMappings: false,
+            hasFieldsForAAD: false,
           },
         ]),
         {
@@ -449,6 +473,8 @@ describe('asEsDslFiltersByRuleTypeAndConsumer', () => {
               myAppWithSubFeature: { read: true, all: true },
             },
             enabledInLicense: true,
+            hasAlertsMappings: false,
+            hasFieldsForAAD: false,
           },
           {
             actionGroups: [],
@@ -466,6 +492,8 @@ describe('asEsDslFiltersByRuleTypeAndConsumer', () => {
               myAppWithSubFeature: { read: true, all: true },
             },
             enabledInLicense: true,
+            hasAlertsMappings: false,
+            hasFieldsForAAD: false,
           },
           {
             actionGroups: [],
@@ -483,6 +511,8 @@ describe('asEsDslFiltersByRuleTypeAndConsumer', () => {
               myAppWithSubFeature: { read: true, all: true },
             },
             enabledInLicense: true,
+            hasAlertsMappings: false,
+            hasFieldsForAAD: false,
           },
         ]),
         {
@@ -646,6 +676,8 @@ describe('asEsDslFiltersByRuleTypeAndConsumer', () => {
           isExportable: true,
           authorizedConsumers: {},
           enabledInLicense: true,
+          hasAlertsMappings: false,
+          hasFieldsForAAD: false,
         },
       ]),
       {

x-pack/plugins/alerting/server/routes/health.test.ts

@@ -49,6 +49,8 @@ const ruleTypes = [
     enabledInLicense: true,
     minimumScheduleInterval: '1m',
     defaultScheduleInterval: '10m',
+    hasAlertsMappings: false,
+    hasFieldsForAAD: false,
   } as RegistryAlertTypeWithAuth,
 ];
 

x-pack/plugins/alerting/server/routes/legacy/health.test.ts

@@ -53,6 +53,8 @@ const ruleTypes = [
     producer: 'test',
     enabledInLicense: true,
     defaultScheduleInterval: '10m',
+    hasAlertsMappings: false,
+    hasFieldsForAAD: false,
   } as RegistryAlertTypeWithAuth,
 ];
 

x-pack/plugins/alerting/server/routes/legacy/list_alert_types.test.ts

@@ -62,6 +62,8 @@ describe('listAlertTypesRoute', () => {
         },
         producer: 'test',
         enabledInLicense: true,
+        hasAlertsMappings: false,
+        hasFieldsForAAD: false,
       } as RegistryAlertTypeWithAuth,
     ];
     rulesClient.listRuleTypes.mockResolvedValueOnce(new Set(listTypes));
@@ -85,6 +87,8 @@ describe('listAlertTypesRoute', () => {
             "authorizedConsumers": Object {},
             "defaultActionGroupId": "default",
             "enabledInLicense": true,
+            "hasAlertsMappings": false,
+            "hasFieldsForAAD": false,
             "id": "1",
             "isExportable": true,
             "minimumLicenseRequired": "basic",
@@ -137,6 +141,8 @@ describe('listAlertTypesRoute', () => {
         },
         producer: 'alerts',
         enabledInLicense: true,
+        hasAlertsMappings: false,
+        hasFieldsForAAD: false,
       } as RegistryAlertTypeWithAuth,
     ];
 
@@ -190,6 +196,8 @@ describe('listAlertTypesRoute', () => {
         },
         producer: 'alerts',
         enabledInLicense: true,
+        hasAlertsMappings: false,
+        hasFieldsForAAD: false,
       } as RegistryAlertTypeWithAuth,
     ];
 

x-pack/plugins/alerting/server/routes/rule_types.test.ts

@@ -61,6 +61,7 @@ describe('ruleTypesRoute', () => {
         defaultScheduleInterval: '10m',
         doesSetRecoveryContext: false,
         hasAlertsMappings: true,
+        hasFieldsForAAD: false,
       } as RegistryAlertTypeWithAuth,
     ];
     const expectedResult: Array<AsApiContract<RegistryAlertTypeWithAuth>> = [
@@ -169,6 +170,8 @@ describe('ruleTypesRoute', () => {
         },
         producer: 'alerts',
         enabledInLicense: true,
+        hasAlertsMappings: false,
+        hasFieldsForAAD: false,
       } as RegistryAlertTypeWithAuth,
     ];
 
@@ -222,6 +225,8 @@ describe('ruleTypesRoute', () => {
         },
         producer: 'alerts',
         enabledInLicense: true,
+        hasAlertsMappings: false,
+        hasFieldsForAAD: false,
       } as RegistryAlertTypeWithAuth,
     ];
 

x-pack/plugins/alerting/server/rule_type_registry.ts

@@ -67,6 +67,8 @@ export interface RegistryRuleType
   > {
   id: string;
   enabledInLicense: boolean;
+  hasFieldsForAAD: boolean;
+  hasAlertsMappings: boolean;
 }
 
 /**
@@ -362,26 +364,28 @@ export class RuleTypeRegistry {
   }
 
   public list(): Set<RegistryRuleType> {
-    return new Set(
-      Array.from(this.ruleTypes).map(
-        ([
-          id,
-          {
-            name,
-            actionGroups,
-            recoveryActionGroup,
-            defaultActionGroupId,
-            actionVariables,
-            producer,
-            minimumLicenseRequired,
-            isExportable,
-            ruleTaskTimeout,
-            defaultScheduleInterval,
-            doesSetRecoveryContext,
-            alerts,
-            fieldsForAAD,
-          },
-        ]: [string, UntypedNormalizedRuleType]) => ({
+    const mapRuleTypes: Array<[string, UntypedNormalizedRuleType]> = Array.from(this.ruleTypes);
+    const tempRegistryRuleType = mapRuleTypes.map<RegistryRuleType>(
+      ([
+        id,
+        {
+          name,
+          actionGroups,
+          recoveryActionGroup,
+          defaultActionGroupId,
+          actionVariables,
+          producer,
+          minimumLicenseRequired,
+          isExportable,
+          ruleTaskTimeout,
+          defaultScheduleInterval,
+          doesSetRecoveryContext,
+          alerts,
+          fieldsForAAD,
+        },
+      ]) => {
+        // KEEP the type here to be safe if not the map is  ignoring it for some reason
+        const ruleType: RegistryRuleType = {
           id,
           name,
           actionGroups,
@@ -402,9 +406,11 @@ export class RuleTypeRegistry {
           hasFieldsForAAD: Boolean(fieldsForAAD),
           hasAlertsMappings: !!alerts,
           ...(alerts ? { alerts } : {}),
-        })
-      )
+        };
+        return ruleType;
+      }
     );
+    return new Set(tempRegistryRuleType);
   }
 
   public getAllTypes(): string[] {

x-pack/plugins/alerting/server/rules_client/tests/aggregate.test.ts

@@ -74,6 +74,8 @@ describe('aggregate()', () => {
       name: 'myType',
       producer: 'myApp',
       enabledInLicense: true,
+      hasAlertsMappings: false,
+      hasFieldsForAAD: false,
     },
   ]);
   beforeEach(() => {
@@ -156,6 +158,8 @@ describe('aggregate()', () => {
             myApp: { read: true, all: true },
           },
           enabledInLicense: true,
+          hasAlertsMappings: false,
+          hasFieldsForAAD: false,
         },
       ])
     );

x-pack/plugins/alerting/server/rules_client/tests/find.test.ts

@@ -82,6 +82,8 @@ describe('find()', () => {
       name: 'myType',
       producer: 'myApp',
       enabledInLicense: true,
+      hasAlertsMappings: false,
+      hasFieldsForAAD: false,
     },
   ]);
   beforeEach(() => {
@@ -142,6 +144,8 @@ describe('find()', () => {
             myApp: { read: true, all: true },
           },
           enabledInLicense: true,
+          hasAlertsMappings: false,
+          hasFieldsForAAD: false,
         },
       ])
     );
@@ -453,6 +457,8 @@ describe('find()', () => {
           name: 'myType',
           producer: 'myApp',
           enabledInLicense: true,
+          hasAlertsMappings: false,
+          hasFieldsForAAD: false,
         },
       ])
     );
@@ -659,6 +665,8 @@ describe('find()', () => {
           name: 'myType',
           producer: 'myApp',
           enabledInLicense: true,
+          hasAlertsMappings: false,
+          hasFieldsForAAD: false,
         },
       ])
     );

x-pack/plugins/alerting/server/rules_client/tests/get_tags.test.ts

@@ -61,6 +61,8 @@ const listedTypes = new Set<RegistryRuleType>([
     name: 'myType',
     producer: 'myApp',
     enabledInLicense: true,
+    hasAlertsMappings: false,
+    hasFieldsForAAD: false,
   },
 ]);
 
@@ -112,6 +114,8 @@ describe('getTags()', () => {
             myApp: { read: true, all: true },
           },
           enabledInLicense: true,
+          hasAlertsMappings: false,
+          hasFieldsForAAD: false,
         },
       ])
     );