[Security Solution][Endpoint] Task/policy save modal text change, rem…

…ove duplicate policy details text (#73130) (#73176) [Security Solution][Endpoint] updates policy details text
elastic · Jul 24, 2020 · 0a578f7 · 0a578f7
1 parent 037d28b
commit 0a578f7
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 34 deletions.
diff --git a/x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.test.tsx b/x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.test.tsx
@@ -232,7 +232,7 @@ describe('Policy Details', () => {
         );
         expect(warningCallout).toHaveLength(1);
         expect(warningCallout.text()).toEqual(
-          'This action will update 5 hostsSaving these changes will apply the updates to all active endpoints assigned to this policy'
+          'This action will update 5 hostsSaving these changes will apply updates to all endpoints assigned to this policy'
         );
       });
       it('should close dialog if cancel button is clicked', () => {

diff --git a/x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.tsx b/x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.tsx
@@ -306,7 +306,7 @@ const ConfirmUpdate = React.memo<{
             >
               <FormattedMessage
                 id="xpack.securitySolution.endpoint.policy.details.updateConfirm.warningMessage"
-                defaultMessage="Saving these changes will apply the updates to all active endpoints assigned to this policy"
+                defaultMessage="Saving these changes will apply updates to all endpoints assigned to this policy"
               />
             </EuiCallOut>
             <EuiSpacer size="xl" />

diff --git a/...lugins/security_solution/public/management/pages/policy/view/policy_forms/config_form.tsx b/...lugins/security_solution/public/management/pages/policy/view/policy_forms/config_form.tsx
@@ -34,17 +34,10 @@ export const ConfigForm: React.FC<{
    */
   supportedOss: React.ReactNode;
   children: React.ReactNode;
-  /**
-   * A description for the component.
-   */
-  description: string;
-  /**
-   * The `data-test-subj` attribute to append to a certain child element.
-   */
   dataTestSubj: string;
   /** React Node to be put on the right corner of the card */
   rightCorner: React.ReactNode;
-}> = React.memo(({ type, supportedOss, children, dataTestSubj, rightCorner, description }) => {
+}> = React.memo(({ type, supportedOss, children, dataTestSubj, rightCorner }) => {
   const typeTitle = useMemo(() => {
     return (
       <EuiFlexGroup direction="row" gutterSize="none" alignItems="center">
@@ -85,12 +78,7 @@ export const ConfigForm: React.FC<{
 
   return (
     <PolicyDetailCard>
-      <EuiCard
-        description={description}
-        data-test-subj={dataTestSubj}
-        textAlign="left"
-        title={typeTitle}
-      >
+      <EuiCard description data-test-subj={dataTestSubj} textAlign="left" title={typeTitle}>
         <EuiHorizontalRule margin="m" />
         {children}
       </EuiCard>

diff --git a/...ugins/security_solution/public/management/pages/policy/view/policy_forms/events/linux.tsx b/...ugins/security_solution/public/management/pages/policy/view/policy_forms/events/linux.tsx
@@ -102,12 +102,6 @@ export const LinuxEvents = React.memo(() => {
       type={i18n.translate('xpack.securitySolution.endpoint.policy.details.eventCollection', {
         defaultMessage: 'Event Collection',
       })}
-      description={i18n.translate(
-        'xpack.securitySolution.endpoint.policy.details.eventCollectionLabel',
-        {
-          defaultMessage: 'Event Collection',
-        }
-      )}
       supportedOss={i18n.translate('xpack.securitySolution.endpoint.policy.details.linux', {
         defaultMessage: 'Linux',
       })}

diff --git a/...plugins/security_solution/public/management/pages/policy/view/policy_forms/events/mac.tsx b/...plugins/security_solution/public/management/pages/policy/view/policy_forms/events/mac.tsx
@@ -102,12 +102,6 @@ export const MacEvents = React.memo(() => {
       type={i18n.translate('xpack.securitySolution.endpoint.policy.details.eventCollection', {
         defaultMessage: 'Event Collection',
       })}
-      description={i18n.translate(
-        'xpack.securitySolution.endpoint.policy.details.eventCollectionLabel',
-        {
-          defaultMessage: 'Event Collection',
-        }
-      )}
       supportedOss={i18n.translate('xpack.securitySolution.endpoint.policy.details.mac', {
         defaultMessage: 'Mac',
       })}

diff --git a/...ins/security_solution/public/management/pages/policy/view/policy_forms/events/windows.tsx b/...ins/security_solution/public/management/pages/policy/view/policy_forms/events/windows.tsx
@@ -142,9 +142,6 @@ export const WindowsEvents = React.memo(() => {
       type={i18n.translate('xpack.securitySolution.endpoint.policy.details.eventCollection', {
         defaultMessage: 'Event Collection',
       })}
-      description={i18n.translate('xpack.securitySolution.endpoint.policy.details.windowsLabel', {
-        defaultMessage: 'Windows',
-      })}
       supportedOss={i18n.translate('xpack.securitySolution.endpoint.policy.details.windows', {
         defaultMessage: 'Windows',
       })}

diff --git a/...ecurity_solution/public/management/pages/policy/view/policy_forms/protections/malware.tsx b/...ecurity_solution/public/management/pages/policy/view/policy_forms/protections/malware.tsx
@@ -174,9 +174,6 @@ export const MalwareProtections = React.memo(() => {
         defaultMessage: 'Windows, Mac',
       })}
       dataTestSubj="malwareProtectionsForm"
-      description={i18n.translate('xpack.securitySolution.endpoint.policy.details.malwareLabel', {
-        defaultMessage: 'Malware',
-      })}
       rightCorner={protectionSwitch}
     >
       {radioButtons}