[TSVB] Metrics UI crashes when it is opened from Metrics Ui

elastic · Apr 23, 2021 · 0a05fb2 · 0a05fb2
1 parent 4eb6c22
commit 0a05fb2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/plugins/vis_type_timeseries/public/application/components/vis_types/timeseries/config.js b/src/plugins/vis_type_timeseries/public/application/components/vis_types/timeseries/config.js
@@ -331,8 +331,13 @@ export const TimeseriesConfig = injectI18n(function (props) {
     ? props.model.series_index_pattern
     : props.indexPatternForQuery;
 
-  const initialPalette = {
-    ...model.palette,
+  const initialPalette = model.palette ?? {
+    type: 'palette',
+    name: 'default',
+  };
+
+  const palette = {
+    ...initialPalette,
     name:
       model.split_color_mode === 'kibana'
         ? 'kibana_palette'
@@ -430,7 +435,7 @@ export const TimeseriesConfig = injectI18n(function (props) {
             >
               <PalettePicker
                 palettes={palettesRegistry}
-                activePalette={initialPalette}
+                activePalette={palette}
                 setPalette={handlePaletteChange}
                 color={model.color}
               />

diff --git a/src/plugins/vis_type_timeseries/public/application/lib/get_split_by_terms_color.ts b/src/plugins/vis_type_timeseries/public/application/lib/get_split_by_terms_color.ts
@@ -57,7 +57,7 @@ export const getSplitByTermsColor = ({
         }
       : seriesPalette.params;
 
-  const outputColor = palettesRegistry?.get(paletteName).getColor(
+  const outputColor = palettesRegistry?.get(paletteName || 'default').getColor(
     [
       {
         name: seriesName || emptyLabel,