Address review feedback

elastic · Oct 15, 2020 · 0974a29 · 0974a29
1 parent 5b68f12
commit 0974a29
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/x-pack/test/api_integration/apis/ml/job_validation/cardinality.ts b/x-pack/test/api_integration/apis/ml/job_validation/cardinality.ts
@@ -13,6 +13,8 @@ export default ({ getService }: FtrProviderContext) => {
   const supertest = getService('supertestWithoutAuth');
   const ml = getService('ml');
 
+  const VALIDATED_SEPARATELY = 'this value is not validated directly';
+
   describe('ValidateCardinality', function () {
     before(async () => {
       await esArchiver.loadIfNeeded('ml/ecommerce');
@@ -97,7 +99,7 @@ export default ({ getService }: FtrProviderContext) => {
       const expectedResponse = [
         {
           id: 'cardinality_model_plot_high',
-          modelPlotCardinality: 'WILL BE VALIDATED SEPARATELY BELOW',
+          modelPlotCardinality: VALIDATED_SEPARATELY,
         },
         { id: 'cardinality_partition_field', fieldName: 'order_id' },
       ];

diff --git a/x-pack/test/api_integration/apis/ml/job_validation/validate.ts b/x-pack/test/api_integration/apis/ml/job_validation/validate.ts
@@ -14,6 +14,8 @@ export default ({ getService }: FtrProviderContext) => {
   const supertest = getService('supertestWithoutAuth');
   const ml = getService('ml');
 
+  const VALIDATED_SEPARATELY = 'this value is not validated directly';
+
   describe('Validate job', function () {
     before(async () => {
       await esArchiver.loadIfNeeded('ml/ecommerce');
@@ -252,9 +254,9 @@ export default ({ getService }: FtrProviderContext) => {
         },
         {
           id: 'cardinality_model_plot_high',
-          modelPlotCardinality: 'WILL BE VALIDATED SEPARATELY BELOW',
-          text: 'WILL BE VALIDATED SEPARATELY BELOW',
-          status: 'WILL BE VALIDATED SEPARATELY BELOW',
+          modelPlotCardinality: VALIDATED_SEPARATELY,
+          text: VALIDATED_SEPARATELY,
+          status: VALIDATED_SEPARATELY,
         },
         {
           id: 'cardinality_partition_field',