[7.x] Migrate Security and EncryptedSavedObjects test plugins to the …

…Kibana Platform (#61864)

x-pack/scripts/functional_tests.js

@@ -28,6 +28,7 @@ require('@kbn/test').runTestsCli([
   require.resolve('../test/oidc_api_integration/implicit_flow.config'),
   require.resolve('../test/pki_api_integration/config'),
   require.resolve('../test/login_selector_api_integration/config'),
+  require.resolve('../test/encrypted_saved_objects_api_integration/config'),
   require.resolve('../test/spaces_api_integration/spaces_only/config'),
   require.resolve('../test/spaces_api_integration/security_and_spaces/config_trial'),
   require.resolve('../test/spaces_api_integration/security_and_spaces/config_basic'),

x-pack/test/encrypted_saved_objects_api_integration/config.ts

@@ -0,0 +1,30 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { resolve } from 'path';
+import { FtrConfigProviderContext } from '@kbn/test/types/ftr';
+import { services } from './services';
+
+export default async function({ readConfigFile }: FtrConfigProviderContext) {
+  const xPackAPITestsConfig = await readConfigFile(require.resolve('../api_integration/config.js'));
+
+  return {
+    testFiles: [require.resolve('./tests')],
+    servers: xPackAPITestsConfig.get('servers'),
+    services,
+    junit: {
+      reportName: 'X-Pack Encrypted Saved Objects API Integration Tests',
+    },
+    esTestCluster: xPackAPITestsConfig.get('esTestCluster'),
+    kbnTestServer: {
+      ...xPackAPITestsConfig.get('kbnTestServer'),
+      serverArgs: [
+        ...xPackAPITestsConfig.get('kbnTestServer.serverArgs'),
+        `--plugin-path=${resolve(__dirname, './fixtures/api_consumer_plugin')}`,
+      ],
+    },
+  };
+}

x-pack/test/encrypted_saved_objects_api_integration/fixtures/api_consumer_plugin/kibana.json

@@ -0,0 +1,8 @@
+{
+  "id": "eso",
+  "version": "8.0.0",
+  "kibanaVersion": "kibana",
+  "requiredPlugins": ["encryptedSavedObjects", "spaces"],
+  "server": true,
+  "ui": false
+}

x-pack/test/encrypted_saved_objects_api_integration/fixtures/api_consumer_plugin/server/index.ts

@@ -0,0 +1,78 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { CoreSetup, PluginInitializer } from '../../../../../../src/core/server';
+import { deepFreeze } from '../../../../../../src/core/utils';
+import {
+  EncryptedSavedObjectsPluginSetup,
+  EncryptedSavedObjectsPluginStart,
+} from '../../../../../plugins/encrypted_saved_objects/server';
+import { SpacesPluginSetup } from '../../../../../plugins/spaces/server';
+
+const SAVED_OBJECT_WITH_SECRET_TYPE = 'saved-object-with-secret';
+
+interface PluginsSetup {
+  encryptedSavedObjects: EncryptedSavedObjectsPluginSetup;
+  spaces: SpacesPluginSetup;
+}
+
+interface PluginsStart {
+  encryptedSavedObjects: EncryptedSavedObjectsPluginStart;
+  spaces: never;
+}
+
+export const plugin: PluginInitializer<void, void, PluginsSetup, PluginsStart> = () => ({
+  setup(core: CoreSetup<PluginsStart>, deps) {
+    core.savedObjects.registerType({
+      name: SAVED_OBJECT_WITH_SECRET_TYPE,
+      hidden: false,
+      namespaceAgnostic: false,
+      mappings: deepFreeze({
+        properties: {
+          publicProperty: { type: 'keyword' },
+          publicPropertyExcludedFromAAD: { type: 'keyword' },
+          privateProperty: { type: 'binary' },
+        },
+      }),
+    });
+
+    deps.encryptedSavedObjects.registerType({
+      type: SAVED_OBJECT_WITH_SECRET_TYPE,
+      attributesToEncrypt: new Set(['privateProperty']),
+      attributesToExcludeFromAAD: new Set(['publicPropertyExcludedFromAAD']),
+    });
+
+    core.http.createRouter().get(
+      {
+        path: '/api/saved_objects/get-decrypted-as-internal-user/{id}',
+        validate: { params: value => ({ value }) },
+      },
+      async (context, request, response) => {
+        const [, { encryptedSavedObjects }] = await core.getStartServices();
+        const spaceId = deps.spaces.spacesService.getSpaceId(request);
+        const namespace = deps.spaces.spacesService.spaceIdToNamespace(spaceId);
+
+        try {
+          return response.ok({
+            body: await encryptedSavedObjects.getDecryptedAsInternalUser(
+              SAVED_OBJECT_WITH_SECRET_TYPE,
+              request.params.id,
+              { namespace }
+            ),
+          });
+        } catch (err) {
+          if (encryptedSavedObjects.isEncryptionError(err)) {
+            return response.badRequest({ body: 'Failed to encrypt attributes' });
+          }
+
+          return response.customError({ body: err, statusCode: 500 });
+        }
+      }
+    );
+  },
+  start() {},
+  stop() {},
+});

x-pack/test/encrypted_saved_objects_api_integration/ftr_provider_context.d.ts

@@ -0,0 +1,11 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { GenericFtrProviderContext } from '@kbn/test/types/ftr';
+
+import { services } from './services';
+
+export type FtrProviderContext = GenericFtrProviderContext<typeof services, {}>;

x-pack/test/encrypted_saved_objects_api_integration/services.ts

@@ -0,0 +1,7 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+export { services } from '../api_integration/services';

x-pack/test/plugin_api_integration/test_suites/encrypted_saved_objects/encrypted_saved_objects_api.ts → x-pack/test/encrypted_saved_objects_api_integration/tests/encrypted_saved_objects_api.ts

@@ -6,7 +6,7 @@
 
 import expect from '@kbn/expect';
 import { SavedObject } from 'src/core/server';
-import { FtrProviderContext } from '../../ftr_provider_context';
+import { FtrProviderContext } from '../ftr_provider_context';
 
 export default function({ getService }: FtrProviderContext) {
   const es = getService('legacyEs');

x-pack/test/plugin_api_integration/test_suites/encrypted_saved_objects/index.ts → x-pack/test/encrypted_saved_objects_api_integration/tests/index.ts

@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { FtrProviderContext } from '../../ftr_provider_context';
+import { FtrProviderContext } from '../ftr_provider_context';
 
 export default function({ loadTestFile }: FtrProviderContext) {
   describe('encryptedSavedObjects', function encryptedSavedObjectsSuite() {

x-pack/test/login_selector_api_integration/config.ts

@@ -130,11 +130,6 @@ export default async function({ readConfigFile }: FtrConfigProviderContext) {
             saml2: { order: 5, realm: 'saml2', maxRedirectURLSize: '100b' },
           },
         })}`,
-        '--server.xsrf.whitelist',
-        JSON.stringify([
-          '/api/oidc_provider/token_endpoint',
-          '/api/oidc_provider/userinfo_endpoint',
-        ]),
       ],
     },
   };

x-pack/test/oidc_api_integration/config.ts

@@ -51,12 +51,6 @@ export default async function({ readConfigFile }: FtrConfigProviderContext) {
         `--plugin-path=${plugin}`,
         '--xpack.security.authc.providers=["oidc"]',
         '--xpack.security.authc.oidc.realm="oidc1"',
-        '--server.xsrf.whitelist',
-        JSON.stringify([
-          '/api/security/oidc/initiate_login',
-          '/api/oidc_provider/token_endpoint',
-          '/api/oidc_provider/userinfo_endpoint',
-        ]),
       ],
     },
   };

x-pack/test/oidc_api_integration/fixtures/oidc_provider/kibana.json

@@ -0,0 +1,7 @@
+{
+  "id": "oidc_provider_plugin",
+  "version": "8.0.0",
+  "kibanaVersion": "kibana",
+  "server": true,
+  "ui": false
+}

x-pack/test/oidc_api_integration/fixtures/oidc_provider/index.js → x-pack/test/oidc_api_integration/fixtures/oidc_provider/server/index.ts

@@ -4,16 +4,11 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
+import { PluginInitializer } from '../../../../../../src/core/server';
 import { initRoutes } from './init_routes';
 
-export default function(kibana) {
-  return new kibana.Plugin({
-    name: 'oidcProvider',
-    id: 'oidcProvider',
-    require: ['elasticsearch'],
-
-    init(server) {
-      initRoutes(server);
-    },
-  });
-}
+export const plugin: PluginInitializer<void, void> = () => ({
+  setup: core => initRoutes(core.http.createRouter()),
+  start: () => {},
+  stop: () => {},
+});