fixing issues

elastic · Jul 17, 2023 · 07cac70 · 07cac70
1 parent 990c4ff
commit 07cac70
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 21 deletions.
diff --git a/x-pack/plugins/security_solution/cypress/e2e/inspect/inspect_button.cy.ts b/x-pack/plugins/security_solution/cypress/e2e/inspect/inspect_button.cy.ts
@@ -17,11 +17,7 @@ import {
   openTableInspectModal,
 } from '../../tasks/inspect';
 import { login, visit } from '../../tasks/login';
-import {
-  postDataView,
-  waitForPageToBeLoaded,
-  waitForWelcomePanelToBeLoaded,
-} from '../../tasks/common';
+import { postDataView, waitForWelcomePanelToBeLoaded } from '../../tasks/common';
 import { esArchiverLoad, esArchiverUnload } from '../../tasks/es_archiver';
 import { selectDataView } from '../../tasks/sourcerer';
 
@@ -52,7 +48,6 @@ describe('Inspect Explore pages', () => {
       visit(url, {
         onLoad: () => {
           waitForWelcomePanelToBeLoaded();
-          waitForPageToBeLoaded();
           selectDataView(DATA_VIEW);
         },
       });

diff --git a/x-pack/plugins/security_solution/cypress/e2e/investigations/timelines/row_renderers.cy.ts b/x-pack/plugins/security_solution/cypress/e2e/investigations/timelines/row_renderers.cy.ts
@@ -15,12 +15,7 @@ import {
   TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE_TOOLTIP,
   TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP,
 } from '../../../screens/timeline';
-import {
-  cleanKibana,
-  deleteTimelines,
-  waitForPageToBeLoaded,
-  waitForWelcomePanelToBeLoaded,
-} from '../../../tasks/common';
+import { cleanKibana, deleteTimelines, waitForWelcomePanelToBeLoaded } from '../../../tasks/common';
 import { waitForAllHostsToBeLoaded } from '../../../tasks/hosts/all_hosts';
 
 import { login, visit } from '../../../tasks/login';
@@ -40,7 +35,6 @@ describe('Row renderers', () => {
     visit(HOSTS_URL, {
       onLoad: () => {
         waitForWelcomePanelToBeLoaded();
-        waitForPageToBeLoaded();
         waitForAllHostsToBeLoaded();
       },
     });

diff --git a/x-pack/plugins/security_solution/cypress/tasks/all_cases.ts b/x-pack/plugins/security_solution/cypress/tasks/all_cases.ts
@@ -10,15 +10,12 @@ import {
   ALL_CASES_CREATE_NEW_CASE_BTN,
   EDIT_EXTERNAL_CONNECTION,
 } from '../screens/all_cases';
-import { waitForPageToBeLoaded } from './common';
 
 export const goToCreateNewCase = () => {
   cy.get(ALL_CASES_CREATE_NEW_CASE_BTN, { timeout: 60000 }).click({ force: true });
-  waitForPageToBeLoaded();
 };
 
 export const goToCaseDetails = () => {
-  waitForPageToBeLoaded();
   cy.get(ALL_CASES_NAME).click({ force: true });
 };
 

diff --git a/.../security_solution/cypress/upgrade_e2e/detections/detection_rules/custom_query_rule.cy.ts b/.../security_solution/cypress/upgrade_e2e/detections/detection_rules/custom_query_rule.cy.ts
@@ -36,7 +36,6 @@ import {
 } from '../../../screens/rule_details';
 
 import { getDetails } from '../../../tasks/rule_details';
-import { waitForPageToBeLoaded } from '../../../tasks/common';
 import {
   waitForRulesTableToBeLoaded,
   goToTheRuleDetailsOf,
@@ -81,7 +80,6 @@ describe('After an upgrade, the custom query rule', () => {
     visit(DETECTIONS_RULE_MANAGEMENT_URL);
     waitForRulesTableToBeLoaded();
     goToTheRuleDetailsOf(rule.name);
-    waitForPageToBeLoaded();
     // Possible bug on first attempt sometimes redirects page back to alerts
     // Going to retry the block once
     cy.url().then((url) => {
@@ -92,7 +90,6 @@ describe('After an upgrade, the custom query rule', () => {
         visit(DETECTIONS_RULE_MANAGEMENT_URL);
         waitForRulesTableToBeLoaded();
         goToTheRuleDetailsOf(rule.name);
-        waitForPageToBeLoaded();
       }
     });
     cy.url().should('include', DETECTIONS_RULE_MANAGEMENT_URL);

diff --git a/...ins/security_solution/cypress/upgrade_e2e/detections/detection_rules/threshold_rule.cy.ts b/...ins/security_solution/cypress/upgrade_e2e/detections/detection_rules/threshold_rule.cy.ts
@@ -26,7 +26,6 @@ import {
 
 import { getDetails } from '../../../tasks/rule_details';
 import { expandFirstAlert } from '../../../tasks/alerts';
-import { waitForPageToBeLoaded } from '../../../tasks/common';
 import {
   goToTheRuleDetailsOf,
   waitForRulesTableToBeLoaded,
@@ -76,7 +75,6 @@ describe('After an upgrade, the threshold rule', () => {
     visit(DETECTIONS_RULE_MANAGEMENT_URL);
     waitForRulesTableToBeLoaded();
     goToTheRuleDetailsOf(rule.name);
-    waitForPageToBeLoaded();
   });
 
   it('Has the expected alerts number', () => {