Use kbn/utils to get current kibana version in tests

elastic · Mar 11, 2021 · 063ac5d · 063ac5d
1 parent c79a508
commit 063ac5d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/packages/kbn-es-archiver/package.json b/packages/kbn-es-archiver/package.json
@@ -3,7 +3,7 @@
   "version": "1.0.0",
   "license": "SSPL-1.0 OR Elastic License 2.0",
   "private": "true",
-  "main": "target/packages/kbn-es-archiver/src/index.js",
+  "main": "target/index.js",
   "kibana": {
     "devOnly": true
   },

diff --git a/packages/kbn-es-archiver/src/lib/archives/parse.test.ts b/packages/kbn-es-archiver/src/lib/archives/parse.test.ts
@@ -9,10 +9,14 @@
 import Stream, { PassThrough, Readable, Writable, Transform } from 'stream';
 import { createGzip } from 'zlib';
 
-import { createConcatStream, createListStream, createPromiseFromStreams } from '@kbn/utils';
+import {
+  createConcatStream,
+  createListStream,
+  createPromiseFromStreams,
+  kibanaPackageJson,
+} from '@kbn/utils';
 
 import { createParseArchiveStreams } from './parse';
-import { version as kibanaPackageVersion } from '../../../../../package.json';
 
 describe('esArchiver createParseArchiveStreams', () => {
   describe('{ gzip: false }', () => {
@@ -63,7 +67,7 @@ describe('esArchiver createParseArchiveStreams', () => {
           ]),
           ...createParseArchiveStreams({ gzip: false }),
         ]);
-        return expect(output).toEqual({ [kibanaPackageVersion]: 'enabled' });
+        return expect(output).toEqual({ [kibanaPackageJson.version]: 'enabled' });
       });
 
       it('provides each JSON object as soon as it is parsed', async () => {
@@ -150,6 +154,18 @@ describe('esArchiver createParseArchiveStreams', () => {
 
         expect(output).toEqual([{ a: 1 }, { a: 2 }]);
       });
+
+      it('replaces $KIBANA_PACKAGE_VERSION with the current kibana version', async () => {
+        const output = await createPromiseFromStreams([
+          createListStream([
+            Buffer.from('{'),
+            Buffer.from('"$KIBANA_PACKAGE_VERSION": "enabled"}'),
+          ]),
+          createGzip(),
+          ...createParseArchiveStreams({ gzip: true }),
+        ]);
+        return expect(output).toEqual({ [kibanaPackageJson.version]: 'enabled' });
+      });
     });
 
     it('parses blank files', async () => {