adding check for non time based index

elastic · Jul 5, 2021 · 04879a8 · 04879a8
1 parent e1a3d48
commit 04879a8
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 8 deletions.
diff --git a/...gins/data_visualizer/public/application/common/components/results_links/results_links.tsx b/...gins/data_visualizer/public/application/common/components/results_links/results_links.tsx
@@ -118,7 +118,7 @@ export const ResultsLinks: FC<Props> = ({
 
     Promise.all(
       additionalLinks.map(async ({ canDisplay, getUrl }) => {
-        if ((await canDisplay()) === false) {
+        if ((await canDisplay({ indexPatternId })) === false) {
           return null;
         }
         return getUrl({ globalState, indexPatternId });

diff --git a/...lizer/public/application/index_data_visualizer/components/actions_panel/actions_panel.tsx b/...lizer/public/application/index_data_visualizer/components/actions_panel/actions_panel.tsx
@@ -86,7 +86,7 @@ export const ActionsPanel: FC<Props> = ({
 
     Promise.all(
       additionalLinks.map(async ({ canDisplay, getUrl }) => {
-        if ((await canDisplay()) === false) {
+        if ((await canDisplay({ indexPatternId })) === false) {
           return null;
         }
         return getUrl({ globalState, indexPatternId });

diff --git a/x-pack/plugins/ml/public/application/datavisualizer/file_based/file_datavisualizer.tsx b/x-pack/plugins/ml/public/application/datavisualizer/file_based/file_datavisualizer.tsx
@@ -26,7 +26,13 @@ interface GetUrlParams {
 export const FileDataVisualizerPage: FC = () => {
   useTimefilter({ timeRangeSelector: false, autoRefreshSelector: false });
   const {
-    services: { docLinks, dataVisualizer },
+    services: {
+      docLinks,
+      dataVisualizer,
+      data: {
+        indexPatterns: { get: getIndexPattern },
+      },
+    },
   } = useMlKibana();
   const mlUrlGenerator = useMlUrlGenerator();
   getMlNodeCount();
@@ -52,8 +58,15 @@ export const FileDataVisualizerPage: FC = () => {
             },
           });
         },
-        canDisplay: async () => {
-          return isFullLicense() && checkPermission('canCreateJob') && mlNodesAvailable();
+        canDisplay: async ({ indexPatternId }) => {
+          const { timeFieldName } = await getIndexPattern(indexPatternId);
+
+          return (
+            isFullLicense() &&
+            timeFieldName !== undefined &&
+            checkPermission('canCreateJob') &&
+            mlNodesAvailable()
+          );
         },
       },
       {

diff --git a/x-pack/plugins/ml/public/application/datavisualizer/index_based/index_data_visualizer.tsx b/x-pack/plugins/ml/public/application/datavisualizer/index_based/index_data_visualizer.tsx
@@ -25,7 +25,13 @@ interface GetUrlParams {
 export const IndexDataVisualizerPage: FC = () => {
   useTimefilter({ timeRangeSelector: false, autoRefreshSelector: false });
   const {
-    services: { docLinks, dataVisualizer },
+    services: {
+      docLinks,
+      dataVisualizer,
+      data: {
+        indexPatterns: { get: getIndexPattern },
+      },
+    },
   } = useMlKibana();
   const mlUrlGenerator = useMlUrlGenerator();
   getMlNodeCount();
@@ -66,8 +72,14 @@ export const IndexDataVisualizerPage: FC = () => {
             },
           });
         },
-        canDisplay: async () => {
-          return isFullLicense() && checkPermission('canCreateJob') && mlNodesAvailable();
+        canDisplay: async ({ indexPatternId }) => {
+          const { timeFieldName } = await getIndexPattern(indexPatternId);
+          return (
+            isFullLicense() &&
+            timeFieldName !== undefined &&
+            checkPermission('canCreateJob') &&
+            mlNodesAvailable()
+          );
         },
         dataTestSubj: 'dataVisualizerCreateAdvancedJobCard',
       },