Get rid of populated fields check

elastic · Aug 8, 2023 · 045a50d · 045a50d
1 parent ff3e49b
commit 045a50d
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/...ugins/ml/public/application/components/field_stats_flyout/field_stats_flyout_provider.tsx b/...ugins/ml/public/application/components/field_stats_flyout/field_stats_flyout_provider.tsx
@@ -25,7 +25,15 @@ export const FieldStatsFlyoutProvider: FC<{
   fieldStatsServices: FieldStatsServices;
   timeRangeMs?: TimeRangeMs;
   dslQuery?: FieldStatsProps['dslQuery'];
-}> = ({ dataView, fieldStatsServices, timeRangeMs, dslQuery, children }) => {
+  disablePopulatedFields?: boolean;
+}> = ({
+  dataView,
+  fieldStatsServices,
+  timeRangeMs,
+  dslQuery,
+  disablePopulatedFields = false,
+  children,
+}) => {
   const {
     services: {
       data: { search },
@@ -43,6 +51,7 @@ export const FieldStatsFlyoutProvider: FC<{
   const [populatedFields$] = useState(new BehaviorSubject<Set<string>>(new Set()));
 
   useEffect(() => {
+    if (disablePopulatedFields) return;
     const abortController = new AbortController();
 
     const queryAndRunTimeMappings = getMergedSampleDocsForPopulatedFieldsQuery({

diff --git a/...nalytics/pages/analytics_creation/components/configuration_step/analysis_fields_table.tsx b/...nalytics/pages/analytics_creation/components/configuration_step/analysis_fields_table.tsx
@@ -60,7 +60,7 @@ export const AnalysisFieldsTable: FC<{
       itemsPerPage: number;
     }>({ pageIndex: 0, itemsPerPage: 5 });
 
-    const { handleFieldStatsButtonClick, populatedFields } = useFieldStatsTrigger();
+    const { handleFieldStatsButtonClick } = useFieldStatsTrigger();
 
     const columns = [
       {
@@ -88,7 +88,6 @@ export const AnalysisFieldsTable: FC<{
           return (
             <>
               <FieldStatsInfoButton
-                isEmpty={!populatedFields?.has(name)}
                 field={field}
                 label={name}
                 onButtonClick={handleFieldStatsButtonClick}

diff --git a/...lytics/pages/analytics_creation/components/configuration_step/configuration_step_form.tsx b/...lytics/pages/analytics_creation/components/configuration_step/configuration_step_form.tsx
@@ -579,6 +579,8 @@ export const ConfigurationStepForm: FC<ConfigurationStepProps> = ({
       fieldStatsServices={fieldStatsServices}
       timeRangeMs={indexData.timeRangeMs}
       dslQuery={jobConfigQuery}
+      // DFA wizard already filters out to populated fields
+      disablePopulatedFields={true}
     >
       <Fragment>
         <Messages messages={requestMessages} />