fix test and message

elastic · Dec 19, 2024 · 039eead · 039eead
1 parent 2e7930c
commit 039eead
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/...plugins/shared/integration_assistant/server/integration_builder/build_integration.test.ts b/...plugins/shared/integration_assistant/server/integration_builder/build_integration.test.ts
@@ -292,12 +292,6 @@ describe('isValidName', () => {
     expect(isValidName('anotherValidName')).toBe(true);
   });
 
-  it('should return false for names with numbers', () => {
-    expect(isValidName('invalid123')).toBe(false);
-    expect(isValidName('123invalid')).toBe(false);
-    expect(isValidName('invalid_123')).toBe(false);
-  });
-
   it('should return false for empty string', () => {
     expect(isValidName('')).toBe(false);
   });

diff --git a/...form/plugins/shared/integration_assistant/server/integration_builder/build_integration.ts b/...form/plugins/shared/integration_assistant/server/integration_builder/build_integration.ts
@@ -36,7 +36,7 @@ export async function buildPackage(integration: Integration): Promise<Buffer> {
 
   if (!isValidName(integration.name)) {
     throw new Error(
-      `Invalid integration name: ${integration.name}, Should only contain letters and underscores`
+      `Invalid integration name: ${integration.name}, Should only contain letters, numbers and underscores`
     );
   }
 
@@ -49,7 +49,7 @@ export async function buildPackage(integration: Integration): Promise<Buffer> {
     const dataStreamName = dataStream.name;
     if (!isValidName(dataStreamName)) {
       throw new Error(
-        `Invalid datastream name: ${dataStreamName}, Should only contain letters and underscores`
+        `Invalid datastream name: ${dataStreamName}, Should only contain letters, numbers and underscores`
       );
     }
     const specificDataStreamDir = joinPath(dataStreamsDir, dataStreamName);