addressing PR comments

elastic · May 12, 2020 · 010e52d · 010e52d
1 parent 16247f2
commit 010e52d
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 8 deletions.
diff --git a/x-pack/plugins/apm/public/components/shared/EnvironmentFilter/index.tsx b/x-pack/plugins/apm/public/components/shared/EnvironmentFilter/index.tsx
@@ -67,10 +67,15 @@ function getOptions(environments: string[]) {
 
 export const EnvironmentFilter: React.FC = () => {
   const location = useLocation();
-  const { uiFilters } = useUrlParams();
+  const { uiFilters, urlParams } = useUrlParams();
 
   const { environment } = uiFilters;
-  const { environments, status = 'loading' } = useEnvironments();
+  const { serviceName, start, end } = urlParams;
+  const { environments, status = 'loading' } = useEnvironments({
+    serviceName,
+    start,
+    end
+  });
 
   return (
     <EuiSelect

diff --git a/x-pack/plugins/apm/public/components/shared/ErrorRateAlertTrigger/index.tsx b/x-pack/plugins/apm/public/components/shared/ErrorRateAlertTrigger/index.tsx
@@ -13,6 +13,7 @@ import { ALERT_TYPES_CONFIG } from '../../../../common/alert_types';
 import { ServiceAlertTrigger } from '../ServiceAlertTrigger';
 import { PopoverExpression } from '../ServiceAlertTrigger/PopoverExpression';
 import { useEnvironments, ALL_OPTION } from '../../../hooks/useEnvironments';
+import { useUrlParams } from '../../../hooks/useUrlParams';
 
 export interface ErrorRateAlertTriggerParams {
   windowSize: number;
@@ -30,7 +31,9 @@ interface Props {
 export function ErrorRateAlertTrigger(props: Props) {
   const { setAlertParams, setAlertProperty, alertParams } = props;
 
-  const { environmentOptions } = useEnvironments();
+  const { urlParams } = useUrlParams();
+  const { serviceName, start, end } = urlParams;
+  const { environmentOptions } = useEnvironments({ serviceName, start, end });
 
   const defaults = {
     threshold: 25,

diff --git a/x-pack/plugins/apm/public/components/shared/TransactionDurationAlertTrigger/index.tsx b/x-pack/plugins/apm/public/components/shared/TransactionDurationAlertTrigger/index.tsx
@@ -40,7 +40,9 @@ export function TransactionDurationAlertTrigger(props: Props) {
   const { urlParams } = useUrlParams();
 
   const transactionTypes = useServiceTransactionTypes(urlParams);
-  const { environmentOptions } = useEnvironments();
+
+  const { serviceName, start, end } = urlParams;
+  const { environmentOptions } = useEnvironments({ serviceName, start, end });
 
   if (!transactionTypes.length) {
     return null;

diff --git a/x-pack/plugins/apm/public/hooks/useEnvironments.tsx b/x-pack/plugins/apm/public/hooks/useEnvironments.tsx
@@ -11,7 +11,6 @@ import {
   ENVIRONMENT_NOT_DEFINED,
   ENVIRONMENT_ALL
 } from '../../common/environment_filter_values';
-import { useUrlParams } from './useUrlParams';
 
 export const ALL_OPTION = {
   value: ENVIRONMENT_ALL,
@@ -31,9 +30,15 @@ function getEnvironmentOptions(environments: string[]) {
   return [ALL_OPTION, ...environmentOptions];
 }
 
-export function useEnvironments() {
-  const { urlParams } = useUrlParams();
-  const { serviceName, start, end } = urlParams;
+export function useEnvironments({
+  serviceName,
+  start,
+  end
+}: {
+  serviceName?: string;
+  start?: string;
+  end?: string;
+}) {
   const { data: environments = [], status = 'loading' } = useFetcher(
     callApmApi => {
       if (start && end) {