Skip to content

Commit

Permalink
addressing pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
cauemarcondes committed Dec 16, 2020
1 parent 1e7c498 commit 00a78b8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { px } from '../../../../style/variables';
interface IconPopoverProps {
title: string;
children: React.ReactChild;
onClick: () => void;
onOpen: () => void;
onClose: () => void;
detailsFetchStatus: FETCH_STATUS;
isOpen: boolean;
Expand All @@ -27,7 +27,7 @@ export function IconPopover({
icon,
title,
children,
onClick,
onOpen,
onClose,
detailsFetchStatus,
isOpen,
Expand All @@ -44,7 +44,7 @@ export function IconPopover({
anchorPosition="downCenter"
ownFocus={false}
button={
<EuiButtonEmpty onClick={onClick} data-test-subj={`popover_${title}`}>
<EuiButtonEmpty onClick={onOpen} data-test-subj={`popover_${title}`}>
<EuiIcon type={icon} size="l" color="black" />
</EuiButtonEmpty>
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export function ServiceIcons({ serviceName }: Props) {
icon={item.icon}
detailsFetchStatus={detailsFetchStatus}
title={item.title}
onClick={() => {
onOpen={() => {
setSelectedIconPopover(item.key);
}}
onClose={() => {
Expand Down

0 comments on commit 00a78b8

Please sign in to comment.