-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the plugins
command to Jarvis
#76
Conversation
This add a new command to jarvis that allow you to get the status of the build for the default plugins that we ship with Logstash and it will periodically yield in the #logstash channel to tell us to look after them. You can trigger the query manually like this: ``` @jarvis plugins Jarvis Oops, We have currently *14* plugins jobs failing :sadbazpanda: Failures for branch: *master* logstash-codec-edn, logstash-codec-edn_lines, logstash-codec-es_bulk, logstash-codec-graphite, logstash-codec-json_lines, logstash-codec-multiline, logstash-codec-plain, logstash-filter-kv, logstash-filter-mutate, logstash-filter-split, logstash-filter-xml, logstash-output-elasticsearch, logstash-output-null, logstash-output-statsd ``` It will fetch the following file https://github.com/elastic/logstash/blob/master/rakelib/plugins-metadata.json to get the list of plugins. It can check more than one branch for some plugins, you will have to make a PR to this repository and add your plugin and the additional branch to check to the `plugins_config.yml` file. like this: ``` logstash-output-elasticsearch: - "6.x" ``` This was motivated by logstash-plugins/logstash-input-beats#203 and needed for the migration to jruby 9k
location = "logstash-plugins/#{plugin_name}" | ||
repo = ::Travis::Repository.find(location) | ||
branches = branch_to_monitor(plugin_name) | ||
status[plugin_name] = branches.each_with_object({}) { |branch, hsh| hsh[branch] = repo.branches[branch].passed? } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you use passed?
at the build level it will ignore jobs marked as allowed to fails (like for the feature/9000), But you can check status per job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This add a new command to jarvis that allow you to get the status of the
build for the default plugins that we ship with Logstash and it will
periodically yield in the #logstash channel to tell us to look after them.
You can trigger the query manually like this:
It will fetch the following file https://github.com/elastic/logstash/blob/master/rakelib/plugins-metadata.json to get the list of plugins.
It can check more than one branch for some plugins, you will have
to make a PR to this repository and add your plugin and the additional
branch to check to the
plugins_config.yml
file. like this:This was motivated by logstash-plugins/logstash-input-beats#203
and needed for the migration to jruby 9k