Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the plugins command to Jarvis #76

Closed
wants to merge 3 commits into from

Conversation

ph
Copy link
Contributor

@ph ph commented May 25, 2017

This add a new command to jarvis that allow you to get the status of the
build for the default plugins that we ship with Logstash and it will
periodically yield in the #logstash channel to tell us to look after them.

You can trigger the query manually like this:

@jarvis plugins

Jarvis Oops, We have currently *14* plugins jobs failing :sadbazpanda:
Failures for branch: *master*
logstash-codec-edn, logstash-codec-edn_lines, logstash-codec-es_bulk, logstash-codec-graphite, logstash-codec-json_lines, logstash-codec-multiline, logstash-codec-plain, logstash-filter-kv, logstash-filter-mutate, logstash-filter-split, logstash-filter-xml, logstash-output-elasticsearch, logstash-output-null, logstash-output-statsd

It will fetch the following file https://github.com/elastic/logstash/blob/master/rakelib/plugins-metadata.json to get the list of plugins.

It can check more than one branch for some plugins, you will have
to make a PR to this repository and add your plugin and the additional
branch to check to the plugins_config.yml file. like this:

logstash-output-elasticsearch:
  - "6.x"

This was motivated by logstash-plugins/logstash-input-beats#203
and needed for the migration to jruby 9k

This add a new command to jarvis that allow you to get the status of the
build for the default plugins that we ship with Logstash and it will
periodically yield in the #logstash channel to tell us to look after them.

You can trigger the query manually like this:

```
@jarvis plugins

Jarvis Oops, We have currently *14* plugins jobs failing :sadbazpanda:
Failures for branch: *master*
logstash-codec-edn, logstash-codec-edn_lines, logstash-codec-es_bulk, logstash-codec-graphite, logstash-codec-json_lines, logstash-codec-multiline, logstash-codec-plain, logstash-filter-kv, logstash-filter-mutate, logstash-filter-split, logstash-filter-xml, logstash-output-elasticsearch, logstash-output-null, logstash-output-statsd
```

It will fetch the following file https://github.com/elastic/logstash/blob/master/rakelib/plugins-metadata.json to get the list of plugins.

It can check more than one branch for some plugins, you will have
to make a PR to this repository and add your plugin and the additional
branch to check to the `plugins_config.yml` file. like this:

```
logstash-output-elasticsearch:
  - "6.x"
```

This was motivated by logstash-plugins/logstash-input-beats#203
and needed for the migration to jruby 9k
@elasticsearch-bot elasticsearch-bot self-assigned this May 25, 2017
location = "logstash-plugins/#{plugin_name}"
repo = ::Travis::Repository.find(location)
branches = branch_to_monitor(plugin_name)
status[plugin_name] = branches.each_with_object({}) { |branch, hsh| hsh[branch] = repo.branches[branch].passed? }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you use passed? at the build level it will ignore jobs marked as allowed to fails (like for the feature/9000), But you can check status per job.

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearch-bot
Copy link

Pier-Hugues Pellerin merged this into the following branches!

Branch Commits
master 461d9c6, 4198500, 4add659

elasticsearch-bot pushed a commit that referenced this pull request May 26, 2017
elasticsearch-bot pushed a commit that referenced this pull request May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants