-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O11y][AWS] Rally benchmark aws.vpcflow
#9242
Conversation
🚀 Benchmarks reportTo see the full report comment with |
}, | ||
"log": { | ||
"file": { | ||
"path": "https://elastic-package-aws-bucket-63461.s3.us-east-1.amazonaws.com/extra-samples.log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
"name": "{{ $aws_s3_bucket_arn }}-{{ div $long_num 10000 }}" | ||
}, | ||
"object": { | ||
"key": "extra-samples.log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's more likely that the s3 object changes, rather than the bucket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. I have kept some ranges which will limit the generation of bucket names. Also generated the object
values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please. see my comments
{{- $network_direction := generate "network_direction" }} | ||
{{- $duration_start := generate "duration_start" }} | ||
{{- $duration_end := generate "duration_end" }} | ||
{{- $aws_vpcflow_start := generate "timestamp" | date_modify (print $duration_start) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beware calling generate
multiple times on the same field.
for example here you have timestamp
that's period: -24h
. you could expect to have 20000 timestamp evenly distributed across 24 hours, but since you are calling generate for it 3 times in the template you end up with 60000 (20000 x 3). they will evenly distributed across 24 hours, each 3 of them sequentially will belong to the same document.
in general, every generate
call will apply the generation logic of a new value.
btw, I remember having worked on a vpcflow template before: it was for schema-A (data coming from logs source, ie: the effective vpcflow logs files), rather than for schema-B (data sent from Agent as generated by the integration, ie: what you have here).
You can still reuse most of the thing and merge what you have added here that's not covered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look at elastic/elastic-package#984 (comment) for Data Schemas (schema-A, schema-B, etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for example here you have timestamp that's period: -24h. you could expect to have 20000 timestamp evenly distributed across 24 hours, but since you are calling generate for it 3 times in the template you end up with 60000 (20000 x 3). they will evenly distributed across 24 hours, each 3 of them sequentially will belong to the same document.
Updated to reuse the timestamp
/test benchmark fullreport |
/test |
… into aws_benchmark_vpcflow
… into aws_benchmark_vpcflow
… into aws_benchmark_vpcflow
💚 Build Succeeded
History
cc @aliabbas-elastic |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Proposed commit message
vpcflow
data stream ofAWS
Sample Response
sample_event.json
Checklist
How to test this PR locally
Run this command from package root
elastic-package benchmark rally --benchmark vpcflow-benchmark -v
elastic-package benchmark stream --benchmark vpcflow-benchmark -v
Related issues
Screenshots