Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y] [ SpringBoot] Support GC datastream on springboot 2.x with LTS JDK versions 11,17 and 21 #8405

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

milan-elastic
Copy link
Contributor

@milan-elastic milan-elastic commented Nov 6, 2023

What does this PR do?

Extends support for LTS JDK versions from only 8 to 8, 11,17, and 21 with the latest version of Springboot 2.7.17.

Related issues

@elasticmachine
Copy link

elasticmachine commented Nov 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-21T06:06:41.958+0000

  • Duration: 19 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 36
Skipped 0
Total 36

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@milan-elastic milan-elastic force-pushed the springboot-lts-jdk-support branch from 98e48bf to 92ea9bc Compare November 6, 2023 11:35
@elasticmachine
Copy link

elasticmachine commented Nov 6, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚 3.636
Classes 100.0% (3/3) 💚 3.636
Methods 100.0% (30/30) 💚 7.625
Lines 96.774% (300/310) 👍 8.144
Conditionals 100.0% (0/0) 💚

@milan-elastic milan-elastic self-assigned this Nov 7, 2023
@milan-elastic milan-elastic marked this pull request as ready for review November 7, 2023 12:23
@milan-elastic milan-elastic requested a review from a team as a code owner November 7, 2023 12:23
Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/spring_boot/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/spring_boot/changelog.yml Outdated Show resolved Hide resolved
milan-elastic and others added 3 commits November 8, 2023 13:07
Co-authored-by: subham sarkar <[email protected]>
Co-authored-by: subham sarkar <[email protected]>
@milan-elastic milan-elastic requested a review from shmsr November 8, 2023 07:49
@shmsr shmsr changed the title [O11y] [ SpringBoot] Support GC datastream on springboot 2.x with lts jdk version 11,17,21 [O11y] [ SpringBoot] Support GC datastream on springboot 2.x with LTS JDK versions 11,17 and 21 Nov 10, 2023
@shmsr shmsr added the enhancement New feature or request label Nov 10, 2023
@shmsr
Copy link
Member

shmsr commented Nov 10, 2023

Just a reminder: PR description template tells you to label the PR with bug/enhancement/etc. and not write them in the PR description. Just the labeling with the right type of PR is enough. Like I have just labelled this PR as "enhancement" and removed the same from the description.

@ali786XI ali786XI merged commit 7261c9e into elastic:main Nov 22, 2023
4 checks passed
@elasticmachine
Copy link

Package spring_boot - 1.2.0 containing this change is available at https://epr.elastic.co/search?package=spring_boot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:spring_boot Spring Boot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SpringBoot] Provide support of GC datastream in JDK 11, 17, 21
6 participants