Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apache_tomcat] - Migrate to package-spec v3 #8159

Merged
merged 2 commits into from
Oct 12, 2023
Merged

[apache_tomcat] - Migrate to package-spec v3 #8159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0db7c4b
[apache_tomcat] - removed dotted YAML keys from manifest
shmsr Oct 11, 2023
277ffc8
Update packages/apache_tomcat/changelog.yml
shmsr Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/apache_tomcat/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: 0.14.0
changes:
- description: Update the package format_version to 3.0.0.
type: enhancement
link: https://github.com/elastic/integrations/pull/8159
- version: "0.13.0"
changes:
- description: Adapt fields for changes in file system info
Expand Down
4 changes: 2 additions & 2 deletions ...s/apache_tomcat/data_stream/localhost/_dev/test/pipeline/test-localhost.log-expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,15 @@
"version": "8.7.0"
},
"error": {
"stack_trace": "\n\nAn error occurred at line: [18] in the jsp file: [/hello.jsp]\nLogger cannot be resolved to a type\n15: application.\n16: \u003c/td\u003e\n17: \u003c/tr\u003e\n18: \u003c% Logger logger = Logger.getLogger(this.getClass().getName());%\u003e\n19: \u003c% String message = \"error\"; logger.info( message );%\u003e\n20: \u003c/table\u003e\n21: \n\n\nAn error occurred at line: [18] in the jsp file: [/hello.jsp]\nLogger cannot be resolved\n15: application.\n16: \u003c/td\u003e\n17: \u003c/tr\u003e\n18: \u003c% Logger logger = Logger.getLogger(this.getClass().getName());%\u003e\n19: \u003c% String message = \"error\"; logger.info( message );%\u003e\n20: \u003c/table\u003e\n21: \n\n\nStacktrace:] with root cause\n\torg.apache.jasper.JasperException: Unable to compile class for JSP: \n\nAn error occurred at line: [18] in the jsp file: [/hello.jsp]\nLogger cannot be resolved to a type\n15: application.\n16: \u003c/td\u003e\n17: \u003c/tr\u003e\n18: \u003c% Logger logger = Logger.getLogger(this.getClass().getName());%\u003e\n19: \u003c% String message = \"error\"; logger.info( message );%\u003e\n20: \u003c/table\u003e\n21: \n\n\nAn error occurred at line: [18] in the jsp file: [/hello.jsp]\nLogger cannot be resolved\n15: application.\n16: \u003c/td\u003e\n17: \u003c/tr\u003e\n18: \u003c% Logger logger = Logger.getLogger(this.getClass().getName());%\u003e\n19: \u003c% String message = \"error\"; logger.info( message );%\u003e\n20: \u003c/table\u003e\n21: \n\n\nStacktrace:\n\t\tat org.apache.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:102)\n\t\tat org.apache.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:213)\n\t\tat org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:600)\n\t\tat org.apache.jasper.compiler.Compiler.compile(Compiler.java:381)\n\t\tat org.apache.jasper.compiler.Compiler.compile(Compiler.java:351)\n\t\tat org.apache.jasper.compiler.Compiler.compile(Compiler.java:335)\n\t\tat org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:597)\n\t\tat org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:398)\n\t\tat org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:383)\n\t\tat org.apache.jasper.servlet.JspServlet.service(JspServlet.java:331)\n\t\tat javax.servlet.http.HttpServlet.service(HttpServlet.java:765)\n\t\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)\n\t\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\n\t\tat org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)\n\t\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)\n\t\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\n\t\tat org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:177)\n\t\tat org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)\n\t\tat org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:543)\n\t\tat org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135)\n\t\tat org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)\n\t\tat org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:698)\n\t\tat org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)\n\t\tat org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:367)\n\t\tat org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:639)\n\t\tat org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)\n\t\tat org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:885)\n\t\tat org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1688)\n\t\tat org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)\n\t\tat org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)\n\t\tat org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)\n\t\tat org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)\n\t\tat java.base/java.lang.Thread.run(Thread.java:829)"
"stack_trace": "\n\nAn error occurred at line: [18] in the jsp file: [/hello.jsp]\nLogger cannot be resolved to a type\n15: application.\n16: </td>\n17: </tr>\n18: <% Logger logger = Logger.getLogger(this.getClass().getName());%>\n19: <% String message = \"error\"; logger.info( message );%>\n20: </table>\n21: \n\n\nAn error occurred at line: [18] in the jsp file: [/hello.jsp]\nLogger cannot be resolved\n15: application.\n16: </td>\n17: </tr>\n18: <% Logger logger = Logger.getLogger(this.getClass().getName());%>\n19: <% String message = \"error\"; logger.info( message );%>\n20: </table>\n21: \n\n\nStacktrace:] with root cause\n\torg.apache.jasper.JasperException: Unable to compile class for JSP: \n\nAn error occurred at line: [18] in the jsp file: [/hello.jsp]\nLogger cannot be resolved to a type\n15: application.\n16: </td>\n17: </tr>\n18: <% Logger logger = Logger.getLogger(this.getClass().getName());%>\n19: <% String message = \"error\"; logger.info( message );%>\n20: </table>\n21: \n\n\nAn error occurred at line: [18] in the jsp file: [/hello.jsp]\nLogger cannot be resolved\n15: application.\n16: </td>\n17: </tr>\n18: <% Logger logger = Logger.getLogger(this.getClass().getName());%>\n19: <% String message = \"error\"; logger.info( message );%>\n20: </table>\n21: \n\n\nStacktrace:\n\t\tat org.apache.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:102)\n\t\tat org.apache.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:213)\n\t\tat org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:600)\n\t\tat org.apache.jasper.compiler.Compiler.compile(Compiler.java:381)\n\t\tat org.apache.jasper.compiler.Compiler.compile(Compiler.java:351)\n\t\tat org.apache.jasper.compiler.Compiler.compile(Compiler.java:335)\n\t\tat org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:597)\n\t\tat org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:398)\n\t\tat org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:383)\n\t\tat org.apache.jasper.servlet.JspServlet.service(JspServlet.java:331)\n\t\tat javax.servlet.http.HttpServlet.service(HttpServlet.java:765)\n\t\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)\n\t\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\n\t\tat org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)\n\t\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)\n\t\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\n\t\tat org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:177)\n\t\tat org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)\n\t\tat org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:543)\n\t\tat org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135)\n\t\tat org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)\n\t\tat org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:698)\n\t\tat org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)\n\t\tat org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:367)\n\t\tat org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:639)\n\t\tat org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)\n\t\tat org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:885)\n\t\tat org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1688)\n\t\tat org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)\n\t\tat org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)\n\t\tat org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)\n\t\tat org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)\n\t\tat java.base/java.lang.Thread.run(Thread.java:829)"
},
"event": {
"category": [
"web"
],
"kind": "event",
"module": "apache_tomcat",
"original": "17-Apr-2023 14:21:32.233 SEVERE [http-nio-8080-exec-1] org.apache.catalina.core.StandardWrapperValve.invoke Servlet.service() for servlet [jsp] in context with path [/sample] threw exception [Unable to compile class for JSP: \n\nAn error occurred at line: [18] in the jsp file: [/hello.jsp]\nLogger cannot be resolved to a type\n15: application.\n16: \u003c/td\u003e\n17: \u003c/tr\u003e\n18: \u003c% Logger logger = Logger.getLogger(this.getClass().getName());%\u003e\n19: \u003c% String message = \"error\"; logger.info( message );%\u003e\n20: \u003c/table\u003e\n21: \n\n\nAn error occurred at line: [18] in the jsp file: [/hello.jsp]\nLogger cannot be resolved\n15: application.\n16: \u003c/td\u003e\n17: \u003c/tr\u003e\n18: \u003c% Logger logger = Logger.getLogger(this.getClass().getName());%\u003e\n19: \u003c% String message = \"error\"; logger.info( message );%\u003e\n20: \u003c/table\u003e\n21: \n\n\nStacktrace:] with root cause\n\torg.apache.jasper.JasperException: Unable to compile class for JSP: \n\nAn error occurred at line: [18] in the jsp file: [/hello.jsp]\nLogger cannot be resolved to a type\n15: application.\n16: \u003c/td\u003e\n17: \u003c/tr\u003e\n18: \u003c% Logger logger = Logger.getLogger(this.getClass().getName());%\u003e\n19: \u003c% String message = \"error\"; logger.info( message );%\u003e\n20: \u003c/table\u003e\n21: \n\n\nAn error occurred at line: [18] in the jsp file: [/hello.jsp]\nLogger cannot be resolved\n15: application.\n16: \u003c/td\u003e\n17: \u003c/tr\u003e\n18: \u003c% Logger logger = Logger.getLogger(this.getClass().getName());%\u003e\n19: \u003c% String message = \"error\"; logger.info( message );%\u003e\n20: \u003c/table\u003e\n21: \n\n\nStacktrace:\n\t\tat org.apache.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:102)\n\t\tat org.apache.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:213)\n\t\tat org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:600)\n\t\tat org.apache.jasper.compiler.Compiler.compile(Compiler.java:381)\n\t\tat org.apache.jasper.compiler.Compiler.compile(Compiler.java:351)\n\t\tat org.apache.jasper.compiler.Compiler.compile(Compiler.java:335)\n\t\tat org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:597)\n\t\tat org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:398)\n\t\tat org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:383)\n\t\tat org.apache.jasper.servlet.JspServlet.service(JspServlet.java:331)\n\t\tat javax.servlet.http.HttpServlet.service(HttpServlet.java:765)\n\t\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)\n\t\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\n\t\tat org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)\n\t\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)\n\t\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\n\t\tat org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:177)\n\t\tat org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)\n\t\tat org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:543)\n\t\tat org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135)\n\t\tat org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)\n\t\tat org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:698)\n\t\tat org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)\n\t\tat org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:367)\n\t\tat org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:639)\n\t\tat org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)\n\t\tat org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:885)\n\t\tat org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1688)\n\t\tat org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)\n\t\tat org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)\n\t\tat org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)\n\t\tat org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)\n\t\tat java.base/java.lang.Thread.run(Thread.java:829)",
"original": "17-Apr-2023 14:21:32.233 SEVERE [http-nio-8080-exec-1] org.apache.catalina.core.StandardWrapperValve.invoke Servlet.service() for servlet [jsp] in context with path [/sample] threw exception [Unable to compile class for JSP: \n\nAn error occurred at line: [18] in the jsp file: [/hello.jsp]\nLogger cannot be resolved to a type\n15: application.\n16: </td>\n17: </tr>\n18: <% Logger logger = Logger.getLogger(this.getClass().getName());%>\n19: <% String message = \"error\"; logger.info( message );%>\n20: </table>\n21: \n\n\nAn error occurred at line: [18] in the jsp file: [/hello.jsp]\nLogger cannot be resolved\n15: application.\n16: </td>\n17: </tr>\n18: <% Logger logger = Logger.getLogger(this.getClass().getName());%>\n19: <% String message = \"error\"; logger.info( message );%>\n20: </table>\n21: \n\n\nStacktrace:] with root cause\n\torg.apache.jasper.JasperException: Unable to compile class for JSP: \n\nAn error occurred at line: [18] in the jsp file: [/hello.jsp]\nLogger cannot be resolved to a type\n15: application.\n16: </td>\n17: </tr>\n18: <% Logger logger = Logger.getLogger(this.getClass().getName());%>\n19: <% String message = \"error\"; logger.info( message );%>\n20: </table>\n21: \n\n\nAn error occurred at line: [18] in the jsp file: [/hello.jsp]\nLogger cannot be resolved\n15: application.\n16: </td>\n17: </tr>\n18: <% Logger logger = Logger.getLogger(this.getClass().getName());%>\n19: <% String message = \"error\"; logger.info( message );%>\n20: </table>\n21: \n\n\nStacktrace:\n\t\tat org.apache.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:102)\n\t\tat org.apache.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:213)\n\t\tat org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:600)\n\t\tat org.apache.jasper.compiler.Compiler.compile(Compiler.java:381)\n\t\tat org.apache.jasper.compiler.Compiler.compile(Compiler.java:351)\n\t\tat org.apache.jasper.compiler.Compiler.compile(Compiler.java:335)\n\t\tat org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:597)\n\t\tat org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:398)\n\t\tat org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:383)\n\t\tat org.apache.jasper.servlet.JspServlet.service(JspServlet.java:331)\n\t\tat javax.servlet.http.HttpServlet.service(HttpServlet.java:765)\n\t\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)\n\t\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\n\t\tat org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)\n\t\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)\n\t\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)\n\t\tat org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:177)\n\t\tat org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)\n\t\tat org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:543)\n\t\tat org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135)\n\t\tat org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)\n\t\tat org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:698)\n\t\tat org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78)\n\t\tat org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:367)\n\t\tat org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:639)\n\t\tat org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)\n\t\tat org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:885)\n\t\tat org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1688)\n\t\tat org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)\n\t\tat org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)\n\t\tat org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)\n\t\tat org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)\n\t\tat java.base/java.lang.Thread.run(Thread.java:829)",
"timezone": "UTC",
"type": [
"error"
Expand Down
8 changes: 5 additions & 3 deletions packages/apache_tomcat/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
format_version: 2.3.0
format_version: "3.0.0"
name: apache_tomcat
title: Apache Tomcat
version: "0.13.0"
version: "0.14.0"
description: Collect and parse logs and metrics from Apache Tomcat servers with Elastic Agent.
categories: ["web", "observability"]
type: integration
conditions:
kibana.version: "^8.8.0"
kibana:
version: "^8.8.0"
policy_templates:
- name: Apache Tomcat
title: Apache Tomcat
Expand Down Expand Up @@ -121,3 +122,4 @@ screenshots:
type: image/png
owner:
github: elastic/obs-infraobs-integrations
type: elastic
3 changes: 3 additions & 0 deletions packages/apache_tomcat/validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
errors:
exclude_checks:
- SVR00004 # References in dashboards.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point to the link which mentions the need of this with the latest package spec ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/elastic/package-spec/blob/main/code/go/pkg/specerrors/constants.go

Set of rules that can be skipped if required. Also see: Filter errors

So after the v3 migration, elastic-package build (which also lints the package) needs to pass but it cannot pass if the checks fail. So there's a set of errors although not recommended to skip; can be skipped so that elastic-package build succeeds with zero return code.

Example errors:

Error: building package failed: invalid content found in built zip package: found 3 validation errors:
   1. references found in dashboard kibana/dashboard/apache_tomcat-44a8e0d0-b8f5-11ed-ac9b-cb6bcd97d223.json: apache_tomcat-d0957a70-eda4-11ed-909a-2baec7270d1f (search) (SVR00004)
   2. references found in dashboard kibana/dashboard/apache_tomcat-8fd54a20-1f0d-11ee-9d6b-bb41d08322c8.json: apache_tomcat-1f3c6e30-dd11-11ed-9f4f-d97c9f37d195 (search), apache_tomcat-4d39c820-ddcd-1
1ed-8080-ddad81fe2c3c (search) (SVR00004)
   3. references found in dashboard kibana/dashboard/apache_tomcat-9c66eb10-dd0c-11ed-9f4f-d97c9f37d195.json: apache_tomcat-1f3c6e30-dd11-11ed-9f4f-d97c9f37d195 (search), apache_tomcat-4d39c820-ddcd-1
1ed-8080-ddad81fe2c3c (search) (SVR00004)

Similar thing was done in this PR too.

Copy link
Contributor

@agithomas agithomas Oct 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the general guidance here ? These errors are here because of not having the best practices followed. Should a backlog issue be created for such error overrides and must be relooked (similar to or as part of lens migration initiative)?

cc @lalit-satapathy , @jsoriano

Copy link
Contributor

@ishleenk17 ishleenk17 Oct 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this code is for Visualization by Value,
So does that mean it expexts the visualiztion to be some other way ?
Can we narrow down on these issues? before skipping them ?

Copy link
Member Author

@shmsr shmsr Oct 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishleenk17 found some related issues that could help:

Might have to use the value migration script to address this error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the solution would be to migrate these visualizations by reference to be included by value. You can decide to delay this migration by adding this exclude rule.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep we should make sure we track all the work required to remove these skips. but we don't have to do it as part of the package spec v3 migration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shmsr : Lets have a meta ticket for this effort. We can track all these skips being made as part of that ticket. So that all information can be obtained from one place.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the meta issue is here #8028