-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azure
package to format_version 3.0.0
#8050
Merged
tommyers-elastic
merged 6 commits into
elastic:main
from
tommyers-elastic:update-azure-to-format-version-3
Oct 16, 2023
Merged
Update azure
package to format_version 3.0.0
#8050
tommyers-elastic
merged 6 commits into
elastic:main
from
tommyers-elastic:update-azure-to-format-version-3
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
…pec v3. The changes here primarily consist of: 1. Removing duplicate fields 2. Clarifying type of 'array' fields. 3. Moving root-level 'geo' fields out of external ECS definitions. This one is a little weird - ECS mandates that 'geo' fields should be nested. We get validation errors if we have them as 'external' at root level, but we need to keep them for backwards compatibility. So we add their definitions into the custom mappings files.
tommyers-elastic
force-pushed
the
update-azure-to-format-version-3
branch
from
October 13, 2023 10:31
bf0954d
to
119e6da
Compare
🌐 Coverage report
|
zmoog
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Package azure - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=azure |
12 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
azure
to format_version 3.0.0.The change consists of the following:
elastic-package format
- this is isolated in the first commit and can be excluded to simplify code review.geo
fields at the root level of the package. these need to be removed, but for now we had to add non-external definitions in order to pass the validations.Checklist
changelog.yml
file.