Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NATS] Add connection data stream metric types #7740

Merged
merged 11 commits into from
Oct 12, 2023

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Sep 10, 2023

What does this PR do?

Add metric types for connection data stream fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gpop63 gpop63 self-assigned this Sep 10, 2023
@gpop63 gpop63 mentioned this pull request Sep 10, 2023
30 tasks
@elasticmachine
Copy link

elasticmachine commented Sep 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-10T22:20:27.131+0000

  • Duration: 31 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 2
Total 33

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 10, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (29/29) 💚
Lines 95.522% (192/201)
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 marked this pull request as ready for review September 17, 2023 21:04
@gpop63 gpop63 requested a review from a team as a code owner September 17, 2023 21:04
@gpop63
Copy link
Contributor Author

gpop63 commented Sep 21, 2023

/test

@gpop63
Copy link
Contributor Author

gpop63 commented Sep 21, 2023

After fixing aggregation type for counters.

scrnli_9_21_2023_3-01-07 PM

@gpop63
Copy link
Contributor Author

gpop63 commented Sep 21, 2023

Rollover test
{
  "acknowledged": true,
  "shards_acknowledged": true,
  "old_index": ".ds-metrics-nats.connection-default-2023.09.21-000001",
  "new_index": ".ds-metrics-nats.connection-default-2023.09.21-000002",
  "rolled_over": true,
  "dry_run": false,
  "conditions": {}
}
Mappings
 "nats": {
          "properties": {
            "connection": {
              "properties": {
                "idle_time": {
                  "type": "long",
                  "time_series_metric": "gauge"
                },
                "in": {
                  "properties": {
                    "bytes": {
                      "type": "long",
                      "time_series_metric": "counter"
                    },
                    "messages": {
                      "type": "long",
                      "time_series_metric": "counter"
                    }
                  }
                },
                "name": {
                  "type": "keyword",
                  "time_series_dimension": true
                },
                "out": {
                  "properties": {
                    "bytes": {
                      "type": "long",
                      "time_series_metric": "counter"
                    },
                    "messages": {
                      "type": "long",
                      "time_series_metric": "counter"
                    }
                  }
                },
                "pending_bytes": {
                  "type": "long",
                  "time_series_metric": "gauge"
                },
                "subscriptions": {
                  "type": "long",
                  "time_series_metric": "gauge"
                },
                "uptime": {
                  "type": "long",
                  "time_series_metric": "counter"
                }
              }
            },

description: |
The period the connection is up (sec)
- name: idle_time
type: long
format: duration
metric_type: gauge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you re-confirm this is Gauge, not counter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it's a counter.

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM keeping TSDB scope.

@gpop63 gpop63 merged commit 2f3a9b9 into elastic:main Oct 12, 2023
1 check passed
@elasticmachine
Copy link

Package nats - 1.3.6 containing this change is available at https://epr.elastic.co/search?package=nats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants