-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NATS] Add connection data stream metric types #7740
Conversation
🌐 Coverage report
|
/test |
Rollover test{
"acknowledged": true,
"shards_acknowledged": true,
"old_index": ".ds-metrics-nats.connection-default-2023.09.21-000001",
"new_index": ".ds-metrics-nats.connection-default-2023.09.21-000002",
"rolled_over": true,
"dry_run": false,
"conditions": {}
} Mappings "nats": {
"properties": {
"connection": {
"properties": {
"idle_time": {
"type": "long",
"time_series_metric": "gauge"
},
"in": {
"properties": {
"bytes": {
"type": "long",
"time_series_metric": "counter"
},
"messages": {
"type": "long",
"time_series_metric": "counter"
}
}
},
"name": {
"type": "keyword",
"time_series_dimension": true
},
"out": {
"properties": {
"bytes": {
"type": "long",
"time_series_metric": "counter"
},
"messages": {
"type": "long",
"time_series_metric": "counter"
}
}
},
"pending_bytes": {
"type": "long",
"time_series_metric": "gauge"
},
"subscriptions": {
"type": "long",
"time_series_metric": "gauge"
},
"uptime": {
"type": "long",
"time_series_metric": "counter"
}
}
}, |
description: | | ||
The period the connection is up (sec) | ||
- name: idle_time | ||
type: long | ||
format: duration | ||
metric_type: gauge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you re-confirm this is Gauge, not counter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, it's a counter
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM keeping TSDB scope.
Package nats - 1.3.6 containing this change is available at https://epr.elastic.co/search?package=nats |
What does this PR do?
Add metric types for connection data stream fields.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots