Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Golang] Migrate to GA #7651

Merged
merged 3 commits into from
Oct 5, 2023
Merged

[Golang] Migrate to GA #7651

merged 3 commits into from
Oct 5, 2023

Conversation

harnish-elastic
Copy link
Contributor

  • Enhancement

What does this PR do?

Migrates the integration from BETA to GA.

Related issues

@harnish-elastic harnish-elastic self-assigned this Sep 4, 2023
@harnish-elastic harnish-elastic marked this pull request as ready for review September 4, 2023 13:47
@harnish-elastic harnish-elastic requested a review from a team as a code owner September 4, 2023 13:47
@elasticmachine
Copy link

elasticmachine commented Sep 4, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-05T05:41:46.857+0000

  • Duration: 16 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 4, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 100.0% (16/16) 💚
Lines 95.876% (186/194) 👎 -4.124
Conditionals 100.0% (0/0) 💚

@muthu-mps
Copy link
Contributor

@harnish-elastic - Can you please look into the below comments,

The document references log datastream. But there is no log datastream in this integration. Update the document to remove the log datastream reference if we are not really having log's.

Document Reference

Screenshot 2023-09-13 at 3 44 10 PM Screenshot 2023-09-13 at 3 44 34 PM

Request Tracing Flag

The Enable Request Tracing flag is common for both logs and metrics which use httpjson as an input or this tracing flag is used only for logs datastream in other integrations ?
Screenshot 2023-09-13 at 4 03 15 PM

@harnish-elastic
Copy link
Contributor Author

Request Tracing Flag

The Enable Request Tracing flag is common for both logs and metrics which use httpjson as an input or this tracing flag is used only for logs datastream in other integrations ? Screenshot 2023-09-13 at 4 03 15 PM

The Enable Request Tracing flag is standard for logs and metrics that use httpjson as an input in the integrations.

muthu-mps
muthu-mps approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
04d6a8e 
…into golang-make-ga

Conflicts:
	packages/golang/changelog.yml
	packages/golang/manifest.yml
@harnish-elastic harnish-elastic merged commit 4becaf6 into elastic:main Oct 5, 2023
@elasticmachine
Copy link

Package golang - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=golang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milan-elastic milan-elastic milan-elastic approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

@shmsr shmsr shmsr approved these changes

Assignees

@harnish-elastic harnish-elastic

Labels
Integration:golang Golang
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Golang GA
5 participants
@harnish-elastic @elasticmachine @muthu-mps @shmsr @milan-elastic