Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Set metric type for GKE, Load Balancing, PubSub, Redis and Storage data streams #7569

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

constanca-m
Copy link
Contributor

What does this PR do?

Set metric type for data streams:

  • GKE: metric type document can be found here
  • Load Balancing: metric type documentation can be found here
  • PubSub: metric type documentation can be found here
  • Redis: metric type documentation can be found here
  • Storage: metric type documentation can be found here.

Important note: all delta metrics are gauge metrics. Related issue for that: elastic/elasticsearch#98171.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates to #7555.

@constanca-m constanca-m requested review from a team as code owners August 28, 2023 15:27
Signed-off-by: constanca-m <[email protected]>
@constanca-m constanca-m mentioned this pull request Aug 28, 2023
4 tasks
@elasticmachine
Copy link

elasticmachine commented Aug 28, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-04T06:48:55.723+0000

  • Duration: 19 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 68
Skipped 0
Total 68

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 28, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 87.826% (101/115) 👎 -12.174
Lines 96.0% (1464/1525) 👍 0.167
Conditionals 100.0% (0/0) 💚

@constanca-m constanca-m self-assigned this Aug 28, 2023
@constanca-m constanca-m added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Aug 28, 2023
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@constanca-m constanca-m merged commit b80fd3e into elastic:main Sep 4, 2023
1 check passed
@constanca-m constanca-m deleted the set3-gcp-add-metric-type branch September 4, 2023 07:32
@elasticmachine
Copy link

Package gcp - 2.28.5 containing this change is available at https://epr.elastic.co/search?package=gcp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants