Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][Hadoop] Resolve the conflicts in host.ip field #7564

Merged
merged 5 commits into from
Sep 4, 2023
Merged

[O11y][Hadoop] Resolve the conflicts in host.ip field #7564

merged 5 commits into from
Sep 4, 2023

Conversation

milan-elastic
Copy link
Contributor

@milan-elastic milan-elastic commented Aug 28, 2023 •
edited
Loading

  • Bug

What does this PR do?

  • Added host.ip field in ecs.yml and added re-indexing steps to resolve conflicts for existing users.
  • Added the compatibility section

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Related issues

@milan-elastic milan-elastic self-assigned this Aug 28, 2023
@milan-elastic milan-elastic requested a review from a team as a code owner August 28, 2023 10:46
@elasticmachine
Copy link

elasticmachine commented Aug 28, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-04T10:34:58.602+0000

  • Duration: 21 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 28, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (9/9) 💚 3.659
Classes 100.0% (9/9) 💚 3.659
Methods 100.0% (47/47) 💚 8.333
Lines 99.18% (605/610) 👍 7.125
Conditionals 100.0% (0/0) 💚

@milan-elastic milan-elastic added Integration:hadoop Hadoop bugfix Pull request that fixes a bug issue labels Aug 28, 2023
muthu-mps
muthu-mps approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ishleenk17
ishleenk17 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@milan-elastic milan-elastic merged commit 4c3ebff into elastic:main Sep 4, 2023
@elasticmachine
Copy link

Package hadoop - 0.9.1 containing this change is available at https://epr.elastic.co/search?package=hadoop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harnish-elastic harnish-elastic harnish-elastic approved these changes

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

Assignees

@milan-elastic milan-elastic

Labels
bugfix Pull request that fixes a bug issue Integration:hadoop Hadoop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][Hadoop] Conflicts in host.ip field
5 participants
@milan-elastic @elasticmachine @muthu-mps @ishleenk17 @harnish-elastic