[O11y][Citrix ADC] Resolve the conflicts in host.ip field #7509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milan-elastic
added
Integration:Citrix-Netscaler
bugfix
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
harnish-elastic
approved these changes
Aug 24, 2023
muthu-mps
reviewed
Aug 28, 2023
muthu-mps
reviewed
Aug 29, 2023
ishleenk17
reviewed
Sep 4, 2023
| ctx.citrix_adc.system.memory.size.value = convert(ctx.citrix_adc.system.memory.size.value); | ||
| } | ||
| if(ctx.citrix_adc?.system?.memory?.usage?.value!=null || ctx.citrix_adc?.system?.memory?.usage?.value!=""){ | ||
| if(ctx.citrix_adc?.system?.memory?.usage?.value!=null && ctx.citrix_adc?.system?.memory?.usage?.value!=""){ |
There was a problem hiding this comment.
These changes look to be unrelated ?
There was a problem hiding this comment.
@ishleenk17 Logically this should be the && condition rather than the || condition. I have mentioned this change in description section of the PR.
|
Package citrix_adc - 0.7.1 containing this change is available at https://epr.elastic.co/search?package=citrix_adc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist
changelog.ymlfile.Related issues