Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][WebSphere Application Server] Resolve the conflict in host.ip field #7507

Merged

Conversation

ali786XI
Copy link
Contributor

  • Bug

What does this PR do?

Added host.ip field in ecs.yml and added re-indexing steps to resolve conflicts for existing users.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Related issues

@ali786XI ali786XI added Integration:websphere_application_server WebSphere Application Server bugfix Pull request that fixes a bug issue labels Aug 23, 2023
@ali786XI ali786XI self-assigned this Aug 23, 2023
@ali786XI ali786XI requested a review from a team as a code owner August 23, 2023 13:03
@ali786XI ali786XI changed the title Resolve the confrict in host.ip field [O11y][WebSphere Application Server] Resolve the conflict in host.ip field Aug 23, 2023
@elasticmachine
Copy link

elasticmachine commented Aug 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-04T12:57:44.184+0000

  • Duration: 29 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 23, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (28/28) 💚
Lines 100.0% (488/488) 💚 1.727
Conditionals 100.0% (0/0) 💚

@@ -11,6 +11,103 @@ This integration uses Prometheus to collect above metrics.

To open Prometheus endpoint read following [instructions](https://www.ibm.com/docs/en/was/9.0.5?topic=mosh-displaying-pmi-metrics-in-prometheus-format-metrics-app).

### Troubleshooting

Conflicts in any field in any data stream can be solved by reindexing the data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the description on when to perform reindexing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @muthu-mps for pointing it out. I referenced this PR and it seems we don't need this line as the below one specifies when to perform reindexing. Let me know if that is what you suggested.

@ali786XI ali786XI requested a review from muthu-mps August 29, 2023 10:11
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ali786XI ali786XI merged commit b9623f8 into elastic:main Sep 4, 2023
@elasticmachine
Copy link

Package websphere_application_server - 0.8.1 containing this change is available at https://epr.elastic.co/search?package=websphere_application_server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:websphere_application_server WebSphere Application Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O11y][WebSphere Application Server] Conflicts in host.ip field
4 participants