Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][GoLang] Resolve the conflict in host.ip field #7494

Merged

Conversation

harnish-elastic
Copy link
Contributor

  • Bug

What does this PR do?

Added host.ip field in ecs.yml and added re-indexing steps to resolve conflicts for existing users.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Related issues

@harnish-elastic harnish-elastic added Integration:golang Golang bugfix Pull request that fixes a bug issue labels Aug 22, 2023
@harnish-elastic harnish-elastic self-assigned this Aug 22, 2023
@harnish-elastic harnish-elastic marked this pull request as ready for review August 22, 2023 11:11
@harnish-elastic harnish-elastic requested a review from a team as a code owner August 22, 2023 11:11
@elasticmachine
Copy link

elasticmachine commented Aug 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-28T12:34:16.959+0000

  • Duration: 15 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 22, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 8.333
Classes 100.0% (2/2) 💚 8.333
Methods 100.0% (16/16) 💚 14.844
Lines 95.833% (184/192) 👍 3.374
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@harnish-elastic harnish-elastic merged commit fe8cb5c into elastic:main Aug 29, 2023
@elasticmachine
Copy link

Package golang - 0.4.1 containing this change is available at https://epr.elastic.co/search?package=golang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:golang Golang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O11y][Golang] Conflicts in host.ip field
4 participants