Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Azure Metrics] Migrate dashboards to by_value #7320

Merged

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Aug 9, 2023

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

As a best practice, this would move visualisations to by_value instead of by_reference

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Commands used for an integration:

  • elastic-package stack down && elastic-package stack up --version=x.y.z -d -v (x.y.z values taken from kibana.version in the package's manifest.yml)
  • cd legacy_vis_analyzer (cloned from https://github.com/flash1293/legacy_vis_analyzer)
  • KIBANA="https://elastic:changeme@localhost:5601" NODE_TLS_REJECT_UNAUTHORIZED='0' node inline.js ./elastic/integrations/packages/azure_metrics/kibana/

Sample output:

Prepared 101 visualizations to be inlined
Processing dashboard [Azure Metrics] Queue Storage Overview
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 3 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
Processing dashboard [Azure Metrics] Storage Overview
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 3 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
Inlined a vis, pushed 0 inner references
... ...
Inlined 101 visualizations
Inlined 0 maps
Inlined 0 lenses
Removing visualization folder
Writing back dashboards

Screenshot of dashboard

image

@rajvi-patel-22 rajvi-patel-22 self-assigned this Aug 9, 2023
@rajvi-patel-22 rajvi-patel-22 added Integration:azure_metrics Azure Resource Metrics enhancement New feature or request dashboard Relates to a Kibana dashboard bug, enhancement, or modification. labels Aug 9, 2023
@elasticmachine
Copy link

elasticmachine commented Aug 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-16T08:05:55.817+0000

  • Duration: 14 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 33
Skipped 0
Total 33

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 9, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 73.333% (22/30) 👎 -26.667
Lines 100.0% (21/21) 💚 1.954
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review August 9, 2023 12:17
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner August 9, 2023 12:17
Copy link
Contributor

@gpop63 gpop63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit 3f2be21 into elastic:main Aug 16, 2023
@elasticmachine
Copy link

Package azure_metrics - 1.0.21 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:azure_metrics Azure Resource Metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants