-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O11y][Azure Metrics] Migrate dashboards to by_value #7320
Merged
rajvi-patel-22
merged 5 commits into
elastic:main
from
rajvi-patel-22:azure-metrics-by-value-migration
Aug 16, 2023
Merged
[O11y][Azure Metrics] Migrate dashboards to by_value #7320
rajvi-patel-22
merged 5 commits into
elastic:main
from
rajvi-patel-22:azure-metrics-by-value-migration
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…saved object clutter and reduce time to load
rajvi-patel-22
added
Integration:azure_metrics
Azure Resource Metrics
enhancement
New feature or request
dashboard
Relates to a Kibana dashboard bug, enhancement, or modification.
labels
Aug 9, 2023
🌐 Coverage report
|
gpop63
approved these changes
Aug 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zmoog
approved these changes
Aug 14, 2023
kush-elastic
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…re-metrics-by-value-migration
Package azure_metrics - 1.0.21 containing this change is available at https://epr.elastic.co/search?package=azure_metrics |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dashboard
Relates to a Kibana dashboard bug, enhancement, or modification.
enhancement
New feature or request
Integration:azure_metrics
Azure Resource Metrics
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Urgency
Activity Type
What does this PR do?
As a best practice, this would move visualisations to by_value instead of by_reference
Checklist
changelog.yml
file.Related issues
Commands used for an integration:
elastic-package stack down && elastic-package stack up --version=x.y.z -d -v
(x.y.z values taken fromkibana.version
in the package'smanifest.yml
)cd legacy_vis_analyzer
(cloned from https://github.com/flash1293/legacy_vis_analyzer)KIBANA="https://elastic:changeme@localhost:5601" NODE_TLS_REJECT_UNAUTHORIZED='0' node inline.js ./elastic/integrations/packages/azure_metrics/kibana/
Sample output:
Screenshot of dashboard