Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS][API Gateway] Fix metric type #6952

Merged
merged 4 commits into from
Jul 14, 2023

Conversation

constanca-m
Copy link
Contributor

@constanca-m constanca-m commented Jul 13, 2023

What does this PR do?

All metric fields are calculated through an aggregation (sum or avg). However, this is only for a given timestamp. On the next timestamp, new values will be used on the final aggregation and so on.

Because of this, the value for some field, 4XXError.sum for example, does not relate to the next 4XXError.sum field. The values are not cumulative over the different timestamps, and that is a requirement for a counter field.

All metric fields are gauge in this data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates to #6293.

Signed-off-by: constanca-m <[email protected]>
@constanca-m constanca-m requested a review from a team as a code owner July 13, 2023 15:21
Signed-off-by: constanca-m <[email protected]>
@elasticmachine
Copy link

elasticmachine commented Jul 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-14T07:16:35.101+0000

  • Duration: 56 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 194
Skipped 4
Total 198

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16)
Classes 93.75% (15/16)
Methods 85.714% (240/280)
Lines 85.925% (7387/8597)
Conditionals 100.0% (0/0) 💚

@constanca-m constanca-m merged commit 5d144e4 into elastic:main Jul 14, 2023
@constanca-m constanca-m deleted the api-gateway-metrics branch July 14, 2023 08:17
@elasticmachine
Copy link

Package aws - 1.46.5 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants