Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nginx] Add Missing ECS Field Mappings #6920

Closed
wants to merge 6 commits into from

Conversation

MakoWish
Copy link
Contributor

@MakoWish MakoWish commented Jul 11, 2023

Type of change

  • Bug

What does this PR do?

This PR corrects a field mapping conflict in the logs-* Data View from Nginx incorrectly mapping source.geo.dma_code, source.geo.postal_code, and related.ip.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have incremented the version in my package's manifest.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Related issues

Screenshots

conflicts
related ip
source geo dma_code
source geo postal_code

@MakoWish MakoWish changed the title Nginx field mappings [Nginx] Add Missing ECS Field Mappings Jul 11, 2023
@MakoWish MakoWish marked this pull request as ready for review July 11, 2023 16:11
@MakoWish MakoWish requested a review from a team as a code owner July 11, 2023 16:11
@elasticmachine
Copy link

elasticmachine commented Jul 11, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-24T17:26:42.327+0000

  • Duration: 16 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 22
Skipped 0
Total 22

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@botelastic
Copy link

botelastic bot commented Aug 10, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Aug 10, 2023
@efd6
Copy link
Contributor

efd6 commented Aug 13, 2023

/test

@ali786XI
Copy link
Contributor

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 50.0% (2/4) 👎 -50.0
Classes 50.0% (2/4) 👎 -50.0
Methods 69.231% (27/39) 👎 -30.769
Lines 70.37% (228/324) 👎 -29.63
Conditionals 100.0% (0/0) 💚

Copy link
Collaborator

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filing the PR!

- external: ecs
name: destination.domain
- external: ecs
name: destination.geo.city_name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add these mapping for destination.geo.*, as I dont see these fields being populated somewhere in nginx.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not populated by Nginx, but any customer that wants to enrich the data with Geo Location will require these fields to be mapped.

@botelastic
Copy link

botelastic bot commented Oct 13, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Oct 13, 2023
@botelastic
Copy link

botelastic bot commented Nov 12, 2023

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nginx] Missing ECS Field Mappings
6 participants