-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nginx] Add Missing ECS Field Mappings #6920
Conversation
…tegrations into nginx_field_mappings
…tegrations into nginx_field_mappings
a7c83f0
to
34bedd3
Compare
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
/test |
34bedd3
to
efe4698
Compare
/test |
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for filing the PR!
- external: ecs | ||
name: destination.domain | ||
- external: ecs | ||
name: destination.geo.city_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add these mapping for destination.geo.*, as I dont see these fields being populated somewhere in nginx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are not populated by Nginx, but any customer that wants to enrich the data with Geo Location will require these fields to be mapped.
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution! |
Type of change
What does this PR do?
This PR corrects a field mapping conflict in the
logs-*
Data View from Nginx incorrectly mappingsource.geo.dma_code
,source.geo.postal_code
, andrelated.ip
.Checklist
changelog.yml
file.manifest.yml
file.How to test this PR locally
Related issues
Screenshots