Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][AWS] Migrate AWS Security Hub dashboards to lens #6871

Merged
merged 4 commits into from
Jul 24, 2023
Merged

[O11y][AWS] Migrate AWS Security Hub dashboards to lens #6871

merged 4 commits into from
Jul 24, 2023

Conversation

kush-elastic
Copy link
Collaborator

  • Enhancement

What does this PR do?

  • Manually migrate AWS Security Hub dashboard visualizations to the lens in the current Kibana version 8.8.1 itself.

  • Statistics for AWS Security Hub dashboard Lens migration:

AWS Security Hub Dashboards Before Migration       After Migration      
  Map Search Lens Visualization Map Search Lens Visualization
[Logs AWS] Security Hub Summary Dashboard 0 0 5 5 0 0 10 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.8.1 itself.

Related issues

@kush-elastic kush-elastic requested review from a team as code owners July 7, 2023 12:54
@elasticmachine
Copy link

elasticmachine commented Jul 7, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-24T07:23:29.688+0000

  • Duration: 52 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 206
Skipped 4
Total 210

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 7, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👎 -5.556
Classes 94.444% (17/18) 👎 -5.556
Methods 85.953% (257/299) 👎 -14.047
Lines 86.011% (7501/8721) 👎 -5.182
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 added enhancement New feature or request Integration:aws AWS labels Jul 10, 2023
This was referenced Jul 10, 2023
Closed
Closed
mbondyra
mbondyra approved these changes Jul 11, 2023
View reviewed changes
Copy link

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

A small nit to consider: in general pie/donut charts are not recommended for visualizing any data, but I get they add some 'attractiveness' to the dashboard. Other options would be to use treemap instead where it's much easier to notice the real proportions of data. Or even instead of donut, pie looks a bit better because there's more space for labels.

image

Screenshot 2023-07-11 at 15 49 47

@kush-elastic
Copy link
Collaborator Author

This looks good to me!

A small nit to consider: in general pie/donut charts are not recommended

@mbondyra, I agree with your suggestion. I have created backlog issue (#6927) to track this and will raise separate PR for converting these donut charts to pie/treemap.

@rajvi-patel-22 rajvi-patel-22 requested a review from a team July 18, 2023 05:19
kcreddy
kcreddy approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 Please fix the conflicts and merge.
Also we could alternately bump the minor version for enhancements, but it has not been the case with this package.

@kush-elastic
Copy link
Collaborator Author

The dashboards are exported from 8.7.0 due to export issue from 8.8.x (elastic/elastic-package#1354)

@kush-elastic
Merge branch 'main' of https://github.com/kush-elastic/integrations i…
1ae3fd0 
…nto lens_migration-aws-security-hub

Conflicts:
	packages/aws/changelog.yml
	packages/aws/manifest.yml
@kush-elastic kush-elastic force-pushed the lens_migration-aws-security-hub branch from a02f2a9 to 1ae3fd0 Compare July 21, 2023 12:56
@rajvi-patel-22
Copy link
Contributor

/test

1 similar comment
@rajvi-patel-22
Copy link
Contributor

/test

@rajvi-patel-22 rajvi-patel-22 merged commit 4f44bf3 into elastic:main Jul 24, 2023
1 check passed
@elasticmachine
Copy link

Package aws - 1.50.5 containing this change is available at https://epr.elastic.co/search?package=aws

@kcreddy kcreddy mentioned this pull request Jul 27, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

@kcreddy kcreddy kcreddy approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@kush-elastic kush-elastic

Labels
enhancement New feature or request Integration:aws AWS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][AWS] AWS Security Hub Lens Migration
6 participants
@kush-elastic @elasticmachine @rajvi-patel-22 @mbondyra @kcreddy @kaiyan-sheng