-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] [CloudWatch] Add dimensions metadata #6827
[AWS] [CloudWatch] Add dimensions metadata #6827
Conversation
Signed-off-by: Tetiana Kravchenko <[email protected]>
Signed-off-by: Tetiana Kravchenko <[email protected]>
🌐 Coverage report
|
Quick question: why is aws.s3.bucketname a dimension? Isn't a dimension fingerprint enough? |
description: | | ||
Name of a S3 bucket. | ||
- name: dimensions.* | ||
type: object | ||
description: | | ||
Metric dimensions. | ||
- name: dimensions.fingerprint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: naming is simil to other data_strems - #6749
@constanca-m with the default configuration for I assumed it is only used for the S3 metrics. As for the S3 bucket name is not always part of
I assumed it was added explicitly for s3 use case, @elastic/obs-cloud-monitoring could you please clarify it? why this field is declared in cloudwatch data_stream explicitly? Is there any specific reason? Or it should be removed from the fields definition? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed it was added explicitly for s3 use case, https://github.com/orgs/elastic/teams/obs-cloud-monitoring could you please clarify it? why this field is declared in cloudwatch data_stream explicitly? Is there any specific reason? Or it should be removed from the fields definition?
Doesn't sound like a blocker to TSDB then. Even if it is an extra field, that is something that can be changed along the way.
packages/aws/data_stream/cloudwatch_metrics/fields/package-fields.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: Tetiana Kravchenko <[email protected]>
Signed-off-by: Tetiana Kravchenko <[email protected]>
Signed-off-by: Tetiana Kravchenko <[email protected]>
/test |
Signed-off-by: Tetiana Kravchenko <[email protected]>
Package aws - 1.46.8 containing this change is available at https://epr.elastic.co/search?package=aws |
What does this PR do?
aws.dimensions.fingerprint
fieldaws.s3.bucket.name
fieldChecklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Screenshots
Mapping:
Testing with TSDB-migration-test-kit