-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map message field to match_only_text for custom logs input package #6570
Conversation
💚 Build Succeeded
Historycc @gsantoro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM. I basically means by default, the user gets all the ECS mappings for logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and I see the following mapping in the custom logs component template:
{
"_embedded_ecs-message_match_only_text": {
"path_match": "message",
"mapping": {
"type": "match_only_text"
}
}
}
Package log - 2.1.0 containing this change is available at https://epr.elastic.co/search?package=log |
- version: "2.1.0" | ||
changes: | ||
- description: Add mapping for message field | ||
type: enhancement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm too late, but it is actually a bug fix not an enhancement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about this. Is there anything we can do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could fix it in a follow up. Lets just keep it for now and consider it a bug :-)
…6570) * add dynamic mapping to fix message mapping type from keyword to match_only_text * updated changelog * reference to ecs dynamic template in the docs
What does this PR do?
Add support for ECS dynamic templates in the custom logs integration defined in the
log
input packageChecklist
changelog.yml
file.Author's Checklist
How to test this PR locally
message
has mappingmatch_only_text
instead ofkeyword
Related issues
Screenshots