Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][WebSphere Application Server] Release Session Manager, Servlet, Threadpool lens migration work #5870

Merged
merged 4 commits into from
Apr 17, 2023
Merged

[O11y][WebSphere Application Server] Release Session Manager, Servlet, Threadpool lens migration work #5870

merged 4 commits into from
Apr 17, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Apr 12, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

Bump up the package version and release Session Manager, Servlet, Threadpool lens migration work

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner April 12, 2023 09:52
@kush-elastic kush-elastic added enhancement New feature or request v8.3.0 Team:Service-Integrations Label for the Service Integrations team Integration:websphere_application_server WebSphere Application Server labels Apr 12, 2023
@elasticmachine
Copy link

elasticmachine commented Apr 12, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-14T12:47:29.514+0000

  • Duration: 27 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (28/28) 💚
Lines 100.0% (488/488) 💚
Conditionals 100.0% (0/0) 💚

@agithomas
Copy link
Contributor

Can you update the link to the actual PR link of Lens migration ?

@rajvi-patel-22
Copy link
Contributor Author

Can you update the link to the actual PR link of Lens migration ?

@agithomas, Are you suggesting to update changelog like this?

- version: "0.6.0"
  changes:
    - description: Migrate 'Session Manager' and 'Servlet' data-streams visualizations to lens.
      type: enhancement
      link: https://github.com/elastic/integrations/pull/5633
- version: "0.5.0"
  changes:
    - description: Migrate threadpool data-stream visualizations to lens.
      type: enhancement
      link: https://github.com/elastic/integrations/pull/5632
- version: "0.4.0"
  changes:
    - description: Migrate jdbc data-stream visualizations to lens.
      type: enhancement
      link: https://github.com/elastic/integrations/pull/5631

@agithomas
Copy link
Contributor

Atleast the one below

- version: "0.5.0"
  changes:
    - description: Release Session Manager, Servlet, Threadpool lens migration work.
      type: enhancement
      link: https://github.com/elastic/integrations/pull/5870

should be updated. If there are no issues, go with the format suggested above.

@rajvi-patel-22
Copy link
Contributor Author

rajvi-patel-22 commented Apr 13, 2023 •
edited
Loading

Atleast the one below

- version: "0.5.0"
  changes:
    - description: Release Session Manager, Servlet, Threadpool lens migration work.
      type: enhancement
      link: https://github.com/elastic/integrations/pull/5870

should be updated. If there are no issues, go with the format suggested above.

@agithomas, I will update changelog as per your suggestion.

- version: "0.5.0"
  changes:
    - description: Release Session Manager, Servlet, Threadpool lens migration work.
      type: enhancement
      link: https://github.com/elastic/integrations/pull/5870
   - description: Migrate 'Session Manager' and 'Servlet' data-streams visualizations to lens.
      type: enhancement
      link: https://github.com/elastic/integrations/pull/5633
   - description: Migrate threadpool data-stream visualizations to lens.
      type: enhancement
      link: https://github.com/elastic/integrations/pull/5632

@rajvi-patel-22
Copy link
Contributor Author

Atleast the one below

- version: "0.5.0"
  changes:
    - description: Release Session Manager, Servlet, Threadpool lens migration work.
      type: enhancement
      link: https://github.com/elastic/integrations/pull/5870

should be updated. If there are no issues, go with the format suggested above.

@agithomas, I will update changelog as per your suggestion.

- version: "0.5.0"
  changes:
    - description: Release Session Manager, Servlet, Threadpool lens migration work.
      type: enhancement
      link: https://github.com/elastic/integrations/pull/5870
   - description: Migrate 'Session Manager' and 'Servlet' data-streams visualizations to lens.
      type: enhancement
      link: https://github.com/elastic/integrations/pull/5633
   - description: Migrate threadpool data-stream visualizations to lens.
      type: enhancement
      link: https://github.com/elastic/integrations/pull/5632

@agithomas, PR has been updated.

@kush-elastic kush-elastic requested a review from agithomas April 13, 2023 07:42
@kush-elastic
Copy link
Collaborator

/test

@agithomas
Copy link
Contributor

@rajvi-elastic , when i look at the other Lens migration projects, i see that we increase the minor version for every dashboards. It may be best to avoid exception as with this case. Please follow as you mentioned here. Please ensure that the PR links are pointing to the original PR links not to this PR

@rajvi-patel-22
Copy link
Contributor Author

@rajvi-elastic , when i look at the other Lens migration projects, i see that we increase the minor version for every dashboards. It may be best to avoid exception as with this case. Please follow as you mentioned here. Please ensure that the PR links are pointing to the original PR links not to this PR

@agithomas, Updated the changes.

agithomas
agithomas approved these changes Apr 16, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit 28f1ff4 into elastic:main Apr 17, 2023
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Apr 17, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milan-elastic milan-elastic milan-elastic approved these changes

@agithomas agithomas agithomas approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:websphere_application_server WebSphere Application Server Team:Service-Integrations Label for the Service Integrations team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajvi-patel-22 @elasticmachine @agithomas @kush-elastic @milan-elastic