Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][CoreDNS] Migrate CoreDNS visualizations to lens in kibana 8.0.0 #5821

Merged

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Apr 7, 2023

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for CoreDNS integration package

  • Statistics for CoreDNS Lens migration:

CoreDNS Dashboards Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Filebeat CoreDNS] Overview 0 4 4 0
  0 4 4 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.0.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner April 7, 2023 10:58
@kush-elastic kush-elastic added enhancement New feature or request Integration:coredns CoreDNS v8.0.0 Team:Service-Integrations Label for the Service Integrations team labels Apr 7, 2023
@kush-elastic kush-elastic mentioned this pull request Apr 7, 2023
5 tasks
@rajvi-patel-22 rajvi-patel-22 marked this pull request as draft April 7, 2023 11:01
@elasticmachine
Copy link

elasticmachine commented Apr 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-12T04:41:17.593+0000

  • Duration: 15 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 95.455% (21/22)
Lines 85.492% (165/193)
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review April 12, 2023 04:41
@kush-elastic kush-elastic requested a review from agithomas April 12, 2023 04:42
Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rajvi-elastic! Approved!

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit ed84ca0 into elastic:main Apr 13, 2023
@elasticmachine
Copy link

Package coredns - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=coredns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:coredns CoreDNS Team:Service-Integrations Label for the Service Integrations team v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants