Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][MySQL] Migrate [Metrics MySQL] Database Overview dashboard visualizations to lens in kibana 8.8.0 #5819

Merged
merged 8 commits into from
Jul 19, 2023
Merged

[O11y][MySQL] Migrate [Metrics MySQL] Database Overview dashboard visualizations to lens in kibana 8.8.0 #5819

merged 8 commits into from
Jul 19, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Apr 7, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for MySQL integration package

  • Statistics for MySQL Lens migration:

MySQL dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics MySQL] Database Overview 0 16 16 0
  0 16 16 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.6.0 itself.

Related issues

Note:

The Kibana files and before migration dashboard image is not synced. Please find below screenshot to compare before and after migrated panels.
Metrics MySQL Database Overview

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner April 7, 2023 10:17
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Apr 7, 2023
Closed
6 tasks
@kush-elastic kush-elastic added enhancement New feature or request Integration:mysql MySQL v8.6.0 Team:Service-Integrations Label for the Service Integrations team labels Apr 7, 2023
@elasticmachine
Copy link

elasticmachine commented Apr 7, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-19T11:57:53.136+0000

  • Duration: 22 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 41
Skipped 0
Total 41

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 7, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 92.857% (26/28) 👍 67.857
Lines 94.34% (150/159) 👎 -5.66
Conditionals 100.0% (0/0) 💚

@botelastic
Copy link

botelastic bot commented May 11, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label May 11, 2023
@botelastic
Copy link

botelastic bot commented Jun 21, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jun 21, 2023
@rajvi-patel-22 rajvi-patel-22 self-assigned this Jul 10, 2023
@botelastic botelastic bot removed the Stalled label Jul 10, 2023
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner July 14, 2023 12:00
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Jul 17, 2023
Merged
7 tasks
@rajvi-patel-22 rajvi-patel-22 changed the title [O11y][MySQL] Migrate [Metrics MySQL] Database Overview dashboard visualizations to lens in kibana 8.6.0 [O11y][MySQL] Migrate [Metrics MySQL] Database Overview dashboard visualizations to lens in kibana 8.8.0 Jul 18, 2023
@agithomas
Copy link
Contributor

Please share the below information

What version of ES is used for exports dashboard ? Is it 8.8.x or 8.7.0 ?

@agithomas
Copy link
Contributor

@SubhrataK , can you please review the new dashboard layout and suggest should something to be changed?

@rajvi-patel-22
Copy link
Contributor Author

What version of ES is used for exports dashboard ? Is it 8.8.x or 8.7.0 ?

@agithomas Dashboards are exported from 8.8.0. But I am working on exporting dashboards from 8.7.0 as per today's discussion.

@rajvi-patel-22
Copy link
Contributor Author

@agithomas Both MySQL PRs (Metrics PR, Logs PR) are updated with Dashboards exported from 8.7.0.

agithomas
agithomas reviewed Jul 18, 2023
View reviewed changes
packages/mysql/img/metricbeat-mysql.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this Rate of Questions dashboard panel ?

Copy link
Contributor Author

@rajvi-patel-22 rajvi-patel-22 Jul 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This panels uses mysql.status.questions field which represents the number of statements executed by the server.
The rate has been calculated by applying derivatives and max function on this field.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have it renamed as Statements Executed.

@agithomas
Copy link
Contributor

agithomas commented Jul 18, 2023 •
edited
Loading

Can we have some panel grouping here with related panels sharing the same row wherever possible?

  1. Connections
  2. Statements, Query, Commands related panels
  3. Buffer pool
  4. Open tables & thread activity
  5. Others such as network

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Jul 19, 2023
Closed
@rajvi-patel-22 rajvi-patel-22 requested a review from agithomas July 19, 2023 12:38
agithomas
agithomas approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit a77fb7e into elastic:main Jul 19, 2023
@elasticmachine
Copy link

Package mysql - 1.14.0 containing this change is available at https://epr.elastic.co/search?package=mysql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milan-elastic milan-elastic milan-elastic approved these changes

@agithomas agithomas agithomas approved these changes

@kush-elastic kush-elastic Awaiting requested review from kush-elastic

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
enhancement New feature or request Integration:mysql MySQL Team:Service-Integrations Label for the Service Integrations team v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][MySQL] Update MySQL Metrics Dashboard
5 participants
@rajvi-patel-22 @elasticmachine @agithomas @milan-elastic @kush-elastic