-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS][EC2] Add processors to rename and drop fields #5812
Closed
Closed
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b950350
Add processors.
constanca-m 951139b
Update changelog.yml
constanca-m 031efc6
Update ec2.md
constanca-m 4657691
add pipeline test to validate new ingest pipeline for ec2_metrics
tommyers-elastic 6d35362
Merge branch 'main' into add-ec2-processor
constanca-m File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 changes: 96 additions & 0 deletions
96
packages/aws/data_stream/ec2_metrics/elasticsearch/ingest_pipeline/default.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| --- | ||
| description: Pipeline for processing EC2 metrics | ||
| processors: | ||
| - rename: | ||
| ignore_missing: true | ||
| field: aws.ec2.metrics.CPUCreditUsage.avg | ||
| target_field: aws.ec2.cpu.credit_usage | ||
|
|
||
| - rename: | ||
| ignore_missing: true | ||
| field: aws.ec2.metrics.CPUCreditBalance.avg | ||
| target_field: aws.ec2.cpu.credit_balance | ||
|
|
||
| - rename: | ||
| ignore_missing: true | ||
| field: aws.ec2.metrics.CPUSurplusCreditBalance.avg | ||
| target_field: aws.ec2.cpu.surplus_credit_balance | ||
|
|
||
| - rename: | ||
| ignore_missing: true | ||
| field: aws.ec2.metrics.CPUSurplusCreditsCharged.avg | ||
| target_field: aws.ec2.cpu.surplus_credits_charged | ||
|
|
||
| - rename: | ||
| ignore_missing: true | ||
| field: aws.ec2.metrics.StatusCheckFailed.avg | ||
| target_field: aws.ec2.status.check_failed | ||
|
|
||
| - rename: | ||
| ignore_missing: true | ||
| field: aws.ec2.metrics.StatusCheckFailed_Instance.avg | ||
| target_field: aws.ec2.status.check_failed_instance | ||
|
|
||
| - rename: | ||
| ignore_missing: true | ||
| field: aws.ec2.metrics.StatusCheckFailed_System.avg | ||
| target_field: aws.ec2.status.check_failed_system | ||
|
|
||
| - rename: | ||
| ignore_missing: true | ||
| field: aws.ec2.metrics.NetworkIn.rate | ||
| target_field: aws.ec2.network.in.bytes_per_sec | ||
|
|
||
| - rename: | ||
| ignore_missing: true | ||
| field: aws.ec2.metrics.NetworkOut.rate | ||
| target_field: aws.ec2.network.out.bytes_per_sec | ||
|
|
||
| - rename: | ||
| ignore_missing: true | ||
| field: aws.ec2.metrics.NetworkPacketsIn.rate | ||
| target_field: aws.ec2.network.in.packets_per_sec | ||
|
|
||
| - rename: | ||
| ignore_missing: true | ||
| field: aws.ec2.metrics.NetworkPacketsOut.rate | ||
| target_field: aws.ec2.network.out.packets_per_sec | ||
|
|
||
| - rename: | ||
| ignore_missing: true | ||
| field: aws.ec2.metrics.DiskReadBytes.rate | ||
| target_field: aws.ec2.diskio.read.bytes_per_sec | ||
|
|
||
| - rename: | ||
| ignore_missing: true | ||
| field: aws.ec2.metrics.DiskWriteBytes.rate | ||
| target_field: aws.ec2.diskio.write.bytes_per_sec | ||
|
|
||
| - rename: | ||
| ignore_missing: true | ||
| field: aws.ec2.metrics.DiskReadOps.rate | ||
| target_field: aws.ec2.diskio.read.count_per_sec | ||
|
|
||
| - rename: | ||
| ignore_missing: true | ||
| field: aws.ec2.metrics.DiskWriteOps.rate | ||
| target_field: aws.ec2.diskio.write.count_per_sec | ||
|
|
||
| - remove: | ||
| ignore_missing: true | ||
| field: | ||
| - aws.ec2.metrics | ||
| - aws.ec2.cpu.total.pct | ||
| - aws.ec2.diskio.read.bytes | ||
| - aws.ec2.diskio.read.count | ||
| - aws.ec2.diskio.write.bytes | ||
| - aws.ec2.diskio.write.count | ||
| - aws.ec2.network.in.bytes | ||
| - aws.ec2.network.in.packets | ||
| - aws.ec2.network.out.bytes | ||
| - aws.ec2.network.out.packets | ||
|
|
||
| on_failure: | ||
| - set: | ||
| field: 'error.message' | ||
| value: '{{ _ingest.on_failure_message }}' | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think this could be considered a breaking change for customers who have potentially built dashboards on the existing (un-renamed) metrics fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, regarding the
metrics.*maybe it is a breaking change, but it is not in sync with beats. And the documentation is not correct because the fields are mixed up. But maybe the best option is to support both for now. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeh it would avoid worrying about breaking things, but for all other customers means a bunch of duplication which sucks. @vinaychandrasekhar @SubhrataK what do you think? so long as the dashboards still work can we remove fields? the public documentation does mention the fields in the exported fields table, as shown below.
@constanca-m i also added a pipeline test to validate whatever decision we make here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tommyers-elastic @vinayamohandoss @SubhrataK Any updates on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just my two cents.
It might break the dashboards, but I do not think it should be considered a breaking change. Users have to explicitly upgrade the integration, no functionality breaks automatically. We had similar cases in the past (example).
In any case, we can consider bump the version to
1.5.0or even2.0.0to signal the field naming change, if anything.This is a possible option, but it would only delay the inevitable (e.g removing
aws.ec2.metricsfields). I would opt for this only we are really on a tight schedule, to unblock this PR.