Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][Nginx] Migrate [Metrics Nginx] Overview dashboard visualizations to lens in kibana 8.5.0 #5780

Merged
merged 5 commits into from
Apr 6, 2023
Merged

[O11y][Nginx] Migrate [Metrics Nginx] Overview dashboard visualizations to lens in kibana 8.5.0 #5780

merged 5 commits into from
Apr 6, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Apr 4, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate [Metrics Nginx] Overview dashboard visualizations to lens for Nginx integration package

  • Statistics for Nginx Lens migration:

Nginx Dashboards Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics Nginx] Overview 0 9 9 0
  0 9 9 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.5.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner April 4, 2023 09:19
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Apr 4, 2023
Closed
7 tasks
@kush-elastic kush-elastic added enhancement New feature or request Integration:nginx Nginx v8.5.0 Team:Service-Integrations Label for the Service Integrations team labels Apr 4, 2023
@kush-elastic kush-elastic self-requested a review April 4, 2023 09:32
@elasticmachine
Copy link

elasticmachine commented Apr 4, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-05T10:15:02.104+0000

  • Duration: 16 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 4, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 50.0% (2/4) 👎 -50.0
Classes 50.0% (2/4) 👎 -50.0
Methods 69.231% (27/39) 👎 -30.769
Lines 70.37% (228/324) 👎 -27.677
Conditionals 100.0% (0/0) 💚

@milan-elastic
Copy link
Contributor

Approved!

kush-elastic
kush-elastic approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

agithomas
agithomas reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y -axis is missing for some of the panels. Please add the Y-axis and the appropriate labels to Y-axis

@rajvi-patel-22
Copy link
Contributor Author

Y -axis is missing for some of the panels. Please add the Y-axis and the appropriate labels to Y-axis

@agithomas, Below are the suggested Y-axis labels:

Panel Y-axis label
 Active connections [Metrics Nginx] Active
Reading / Writing / Waiting Rates [Metrics Nginx]
Request Rate [Metrics Nginx]
Accepts and Handled Rate [Metrics Nginx]
Drops Rate [Metrics Nginx]		 Rate

Should we update PR with above Y-axis labels?

@agithomas
Copy link
Contributor

Y -axis is missing for some of the panels. Please add the Y-axis and the appropriate labels to Y-axis

@agithomas, Below are the suggested Y-axis labels:

Panel Y-axis label
 Active connections [Metrics Nginx] Active
Reading / Writing / Waiting Rates [Metrics Nginx]
Request Rate [Metrics Nginx]
Accepts and Handled Rate [Metrics Nginx]
Drops Rate [Metrics Nginx] Rate
Should we update PR with above Y-axis labels?

looks good to me. Yes, please.

@rajvi-patel-22
Copy link
Contributor Author

Y -axis is missing for some of the panels. Please add the Y-axis and the appropriate labels to Y-axis

@agithomas, I have updated the PR with suggested Y-axis labels. Can you please review it?

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Apr 5, 2023
Closed
2 tasks
agithomas
agithomas approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit d926ac6 into elastic:main Apr 6, 2023
@elasticmachine
Copy link

Package nginx - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=nginx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kush-elastic kush-elastic kush-elastic approved these changes

@agithomas agithomas agithomas approved these changes

@milan-elastic milan-elastic milan-elastic approved these changes

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
enhancement New feature or request Integration:nginx Nginx Team:Service-Integrations Label for the Service Integrations team v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajvi-patel-22 @elasticmachine @milan-elastic @agithomas @kush-elastic