Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Oracle] Migrate Tablespace dashboard visualizations to lens in kibana 8.6.0 #5754

Merged

Conversation

harnish-elastic
Copy link
Contributor

@harnish-elastic harnish-elastic commented Mar 30, 2023

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Oracle integration package

  • Statistics for Oracle Lens migration:

Oracle Dashboards Before Migration   After Migration
  Lens Visualization Lens Visualization
[Metrics Oracle] Tablespace 0 4 4 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in Kibana version 8.6.0.

Related issues

Issues Identified

@harnish-elastic harnish-elastic mentioned this pull request Mar 30, 2023
10 tasks
@elasticmachine
Copy link

elasticmachine commented Mar 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-13T07:37:59.347+0000

  • Duration: 31 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 30, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (29/29) 💚
Lines 94.318% (249/264)
Conditionals 100.0% (0/0) 💚

@harnish-elastic harnish-elastic marked this pull request as ready for review March 30, 2023 16:52
@harnish-elastic harnish-elastic requested a review from a team as a code owner March 30, 2023 16:52
@kush-elastic kush-elastic added enhancement New feature or request Integration:oracle Oracle Team:Service-Integrations Label for the Service Integrations team labels Mar 30, 2023
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Approved!

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think there exist some difference in the stacked bar chart. Please re-check.
    2 I understand that in the old view, the Y-axis is not converting the bytes to MB / GB. Please see if you can change this .

@harnish-elastic
Copy link
Contributor Author

  1. I think there exist some difference in the stacked bar chart. Please re-check.

I have re-checked the bar chart with populating the data in both dashboards (Before migrated and after migrated), and both after migrated bar stacked charts are behaving same with before migrated bar stacked chart. Let me know if you have find any difference.

2 I understand that in the old view, the Y-axis is not converting the bytes to MB / GB. Please see if you can change this .

Sure, @agithomas, we will enhance this change in this PR itself. Also we have created one enhancement issue for the same to keep track of this thing.

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New representation

image

The view presents, the avg data file size. The representation shows, the file size suddenly is 800MB approx around 3:15pm and becomes zero at 9:15pm. Compare with the image below, it shows a consistent size usage through out.

Not sure , the problem is with graph or with the data ingestion.

image

@agithomas
Copy link
Contributor

New representation

image

The view presents, the avg data file size. The representation shows, the file size suddenly is 800MB approx around 3:15pm and becomes zero at 9:15pm. Compare with the image below, it shows a consistent size usage through out.

Not sure , the problem is with graph or with the data ingestion.

image

Same problem for Tablespace Total size vis panel

@harnish-elastic
Copy link
Contributor Author

New representation

image

The view presents, the avg data file size. The representation shows, the file size suddenly is 800MB approx around 3:15pm and becomes zero at 9:15pm. Compare with the image below, it shows a consistent size usage through out.

Not sure , the problem is with graph or with the data ingestion.

image

New representation
image
The view presents, the avg data file size. The representation shows, the file size suddenly is 800MB approx around 3:15pm and becomes zero at 9:15pm. Compare with the image below, it shows a consistent size usage through out.
Not sure , the problem is with graph or with the data ingestion.
image

Same problem for Tablespace Total size vis panel

@agithomas, I think the issue is not related to chart and data ingestions as well. The data values are same for all the breakdown fields hence it looked like that. I have changed the mocked data values. Please refer the below screenshot.

image

@agithomas
Copy link
Contributor

New representation
image
The view presents, the avg data file size. The representation shows, the file size suddenly is 800MB approx around 3:15pm and becomes zero at 9:15pm. Compare with the image below, it shows a consistent size usage through out.
Not sure , the problem is with graph or with the data ingestion.
image

New representation
image
The view presents, the avg data file size. The representation shows, the file size suddenly is 800MB approx around 3:15pm and becomes zero at 9:15pm. Compare with the image below, it shows a consistent size usage through out.
Not sure , the problem is with graph or with the data ingestion.
image

Same problem for Tablespace Total size vis panel

@agithomas, I think the issue is not related to chart and data ingestions as well. The data values are same for all the breakdown fields hence it looked like that. I have changed the mocked data values. Please refer the below screenshot.

image

Looks good, please update the screenshot file in the PR

@harnish-elastic
Copy link
Contributor Author

@agithomas Updated the PR with requested changes. Thanks!

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…into lens_migration-oracle-tablespace

Conflicts:
	packages/oracle/changelog.yml
	packages/oracle/manifest.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:oracle Oracle Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants