Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][IIS] Migrate Application Pool Overview dashboard visualizations to lens in kibana 8.5.0 #5728

Merged
merged 4 commits into from
Apr 13, 2023
Merged

[O11y][IIS] Migrate Application Pool Overview dashboard visualizations to lens in kibana 8.5.0 #5728

merged 4 commits into from
Apr 13, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for IIS integration package

  • Statistics for IIS Lens migration:

IIS dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
Application Pool Overview 0 9 8 1
  0 9 8 1

Note: 1 markdown panel has not been migrated because we don't have any alternatives in lens for markdown.
1-metricbeat-iis-application-pool-overview

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.5.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 29, 2023 05:52
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 29, 2023
Closed
9 tasks
@kush-elastic kush-elastic added enhancement New feature or request v8.5.0 Integration:iis IIS Team:Service-Integrations Label for the Service Integrations team labels Mar 29, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 29, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-13T08:22:29.651+0000

  • Duration: 15 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 29, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 85.714% (30/35) ❕
Lines 93.772% (271/289) ❕
Conditionals 100.0% (0/0) 💚

@muthu-mps
Copy link
Contributor

Is it possible to remove the decimal places in the percentage representation of the CPU Usage chart ?

@rajvi-patel-22
Copy link
Contributor Author

Is it possible to remove the decimal places in the percentage representation of the CPU Usage chart ?

@muthu-mps, Yes it is possible. But it won't show you the precise value even when you hover over the chart.
In the previous TSVB visualization (before migration), when you hover over the chart it shows precise values. Hence we have kept the precision of 2 decimal places.

Please find the below screenshot of before migration.
image (14)

@muthu-mps
Copy link
Contributor

Is it possible to remove the decimal places in the percentage representation of the CPU Usage chart ?

@muthu-mps, Yes it is possible. But it won't show you the precise value even when you hover over the chart. In the previous TSVB visualization (before migration), when you hover over the chart it shows precise values. Hence we have kept the precision of 2 decimal places.

Please find the below screenshot of before migration. image (14)

@rajvi-elastic - Do we really need three decimal places ? As the CPU Usage chart in Webserver Processes doesn't show decimal places. Is there any difference ?

@rajvi-patel-22
Copy link
Contributor Author

@rajvi-elastic - Do we really need three decimal places ? As the CPU Usage chart in Webserver Processes doesn't show decimal places. Is there any difference ?

@muthu-mps , Please find below image for before migrated CPU Usage chart.
image

Both the panels are showing different formatted values. If it is required to show precise percentage value then we can add decimals point otherwise we can remove it. Please let us know whether or not it is required?

@muthu-mps
Copy link
Contributor

@rajvi-elastic - Do we really need three decimal places ? As the CPU Usage chart in Webserver Processes doesn't show decimal places. Is there any difference ?

@muthu-mps , Please find below image for before migrated CPU Usage chart. image

Both the panels are showing different formatted values. If it is required to show precise percentage value then we can add decimals point otherwise we can remove it. Please let us know whether or not it is required?

As the lens shows the values in the Y axis with decimal values. It would be good to have single decimal value.

@rajvi-patel-22
Copy link
Contributor Author

As the lens shows the values in the Y axis with decimal values. It would be good to have single decimal value.

@muthu-mps, Should we also change decimal values in other IIS panels as well?

For example, in Website Overview dashboard there are few panels in which 3 decimal points are configured.

@muthu-mps
Copy link
Contributor

As the lens shows the values in the Y axis with decimal values. It would be good to have single decimal value.

@muthu-mps, Should we also change decimal values in other IIS panels as well?

For example, in Website Overview dashboard there are few panels in which 3 decimal points are configured.

Yes, Please make the change for other dashboards as well.

@rajvi-patel-22
Copy link
Contributor Author

Yes, Please make the change for other dashboards as well.

@muthu-mps, we have updated the decimal points in panels and updated the PRs. Can you please review it?

@agithomas
Copy link
Contributor

@muthu-mps , can we have your approval.

muthu-mps
muthu-mps approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

muthu-mps
muthu-mps approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rajvi-patel-22
Merge branch 'main' of github.com:rajvi-elastic/integrations into len…
8b8431e 
…s_migration-iis-application-pool-overview-8.5.0
@kush-elastic
Copy link
Collaborator

/test

@kush-elastic kush-elastic merged commit da49ca2 into elastic:main Apr 13, 2023
@elasticmachine
Copy link

Package iis - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=iis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milan-elastic milan-elastic milan-elastic approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

@agithomas agithomas Awaiting requested review from agithomas

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
enhancement New feature or request Integration:iis IIS Team:Service-Integrations Label for the Service Integrations team v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rajvi-patel-22 @elasticmachine @muthu-mps @agithomas @kush-elastic @milan-elastic