-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O11y][HAProxy] Migrate stat data-stream visualizations to lens in kibana 8.4.0 #5611
[O11y][HAProxy] Migrate stat data-stream visualizations to lens in kibana 8.4.0 #5611
Conversation
🌐 Coverage report
|
@agithomas, As we have mentioned in the description, there are 10 panels which have not be migrated to the lens. We have found work around for Currently, we have migrated everything to 8.4.0. In order to migrate this new panel, we will have to upgrade to the newer Kibana version (v8.6.0). Can you please let us know how should we proceed further? |
@rajvi-elastic , are you saying with 8.6.0 migration, we would have 100% lens migration for HAProxy dashboards? |
No @agithomas . Not all the 10 remaining panels could be migrated to the lens. Only one panel which is blocked due to Complex painless script could be migrated. All the other 9 panels are blocked due to elastic/kibana#153326. With v8.6.0 we will be only able to migrate one panel from the list. Other 9 panels would be still visualizations. |
@agithomas, There is one screenshot of the dashboard of the filebeat module. It seems redundant to me, we already have updated the latest screenshot here. If it's not needed now then please remove this from the integration. |
@SubhrataK , is the last bucket issue highlighted here and referred in other integrations can now be considered is not an issue anymore ? @rajvi-elastic , please confirm if the issue is similar to other integrations and there are no edge cases here. |
@lalit-satapathy , what is your take on this? The benefit of migrating to 8.6.0 from 8.4.0 is only for just one panel. My personal preference is to retain this one panel in old vis style and migrate when there exist a proper solution instead of workaround. |
No @agithomas, The issue that is mentioned here is not similar to what we discussed in IBM MQ. We are still discussing this last bucket issue with Kibana team and they have scheduled a call in next week. |
As discussed with @SubhrataK,
|
@agithomas, Can you please help me understand the aggregation that has been used in CC: @SubhrataK |
It appears that the field is of metric_type counter. Avg() function may not be the agg function to use here. It is important to find out the rate of change on counter field and hence derivative() function is used. You may consider changing from avg() to max() while making the lens migration. |
@agithomas, The solution that we have implemented is the same as auto lens migration implements ( Please let us know whether we should migrate to the 8.6.0 or not? |
Please proceed. |
@agithomas, All the panels have been migrated to lens (Kibana v8.6.0). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/haproxy/img/haproxy-metrics-http-frontend.png
have negative values for traffic volume. Please correct them.
@agithomas, this panel uses the differences. This has the similar aggregations as oracle panel.. |
Well, it is understandable from Oracle Integration snapshot, it is not clear here that what is represented is a difference from previous value. In oracle, the actual value was shown and then the line showing the difference is an overlay. I understand that this is how things were in the past . @SubhrataK , can you please have a quick check on this and recommend a suitable title change or a better representation of panel data such as - data + difference value |
@rajvi-elastic , please create a backlog issue for this. It may be best we take it up separately in the interest of time. |
Rest things are good. Version change from 8.0.0 to 8.6.0 needs approval, deferring the PR approval until then. |
@agithomas, I have created the backlog issue. |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution! |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution! |
@rajvi-elastic , please wait till #8204 is merged . |
Another PR has been raised for HAProxy lens migration. |
What does this PR do?
Migrate stat data-stream visualizations to lens for HAProxy integration package
Statistics for HAProxy Lens migration:
Checklist
changelog.yml
file.Author's Checklist
Related issues
Issues
Below 10 panels are not migrated due to lens limitations:DashboardVisualizationReason[Metrics HAProxy] HTTP backendDowntime seconds [Metrics HAProxy]elastic/kibana#153326Connections per server [Metrics HAProxy]elastic/kibana#153326Active servers in backend [Metrics HAProxy]elastic/kibana#153326[Metrics HAProxy] HTTP serverHealthcheck [Metrics HAProxy]Complex painless script[Metrics HAProxy] BackendDowntime seconds [Metrics HAProxy]elastic/kibana#153326Connections per server [Metrics HAProxy]elastic/kibana#153326Active servers in backend [Metrics HAProxy]elastic/kibana#153326[Metrics HAProxy] OverviewFrontendselastic/kibana#153326Backendselastic/kibana#153326Servers visualizationselastic/kibana#153326Note: Please find below screenshots of dashboards (before migration) to compare migrated panels:
[Metrics HAProxy] Overview:
[Metrics HAProxy] HTTP backend:
[Metrics HAProxy] Backend:
[Metrics HAProxy] HTTP Frontend:
[Metrics HAProxy] HTTP server:
[Metrics HAProxy] Frontend: