Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrictype for fields of performance data stream. #5532

Merged

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Mar 14, 2023

  • Enhancement

What does this PR do?

This PR updates the metric_type meta data for fields of performance data stream of mssql

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Add the microsoft_sqlserver integration.
In integration's overview page, metric type could be confirmed.
Enable performance data stream and you should see metrics successfully.

Related issues

@ritalwar ritalwar mentioned this pull request Mar 14, 2023
11 tasks
@elasticmachine
Copy link

elasticmachine commented Mar 14, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-20T12:32:16.058+0000

  • Duration: 16 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 14, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 93.333% (28/30) 👍
Lines 100.0% (1238/1238) 💚
Conditionals 100.0% (0/0) 💚

@ritalwar ritalwar marked this pull request as ready for review March 15, 2023 04:29
@ritalwar ritalwar requested a review from a team as a code owner March 15, 2023 04:29
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit 7e4689c into elastic:main Mar 20, 2023
@elasticmachine
Copy link

Package microsoft_sqlserver - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants