Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dimension fields for performance datastream to support TSDB enabl… #5519

Merged
merged 4 commits into from
Mar 20, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Mar 13, 2023

  • Enhancement

What does this PR do?

This PR add dimensions fields for performance data stream to enable TSDB.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@elasticmachine
Copy link

elasticmachine commented Mar 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-20T11:58:40.843+0000

  • Duration: 16 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 13, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 93.333% (28/30) 👍 7.619
Lines 100.0% (1238/1238) 💚 6.294
Conditionals 100.0% (0/0) 💚

@ritalwar ritalwar mentioned this pull request Mar 14, 2023
11 tasks
@ritalwar ritalwar marked this pull request as ready for review March 15, 2023 04:30
@ritalwar ritalwar requested a review from a team as a code owner March 15, 2023 04:30
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit a41799d into elastic:main Mar 20, 2023
@elasticmachine
Copy link

Package microsoft_sqlserver - 1.14.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
elastic#5519)

* Add dimension fields for performance datastream to support TSDB enablement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants