Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][ActiveMQ] Lens migration for visualizations to Kibana version 8.2.0 #5517

Merged

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Mar 13, 2023

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for ActiveMQ integration package

  • Statistics for ActiveMQ Lens migration:

  Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Logs ActiveMQ] Audit 0 3 3 0
[Logs ActiveMQ] Broker 0 6 6 0
[Logs ActiveMQ] Log 0 2 2 0
[Logs ActiveMQ] Queues 0 8 8 0
[Logs ActiveMQ] Topics 0 8 8 0
  0 27 27 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.2.0 itself.

Related issues

Issues Identified

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 13, 2023 07:18
@elasticmachine
Copy link

elasticmachine commented Mar 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-21T06:26:58.024+0000

  • Duration: 21 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 13, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 95.833% (23/24) 👎 -3.172
Lines 85.321% (93/109) 👎 -8.875
Conditionals 100.0% (0/0) 💚

Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas requested a review from muthu-mps March 14, 2023 14:19
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the image names by removing the filebeat and metricbeat prefix ?

@rajvi-patel-22
Copy link
Contributor Author

Can we rename the image names by removing the filebeat and metricbeat prefix ?

These names are already there in the current codebase. This is just the lens migration PR so we won't be changing any behavior/files as a part of this PR otherwise it will mess it up. However, If you strongly feel that this change needs to be done then we can raise a separate issue for that and track them separately.

@agithomas
Copy link
Contributor

These names are already there in the current codebase. This is just the lens migration PR so we won't be changing any behavior/files as a part of this PR otherwise it will mess it up. However, If you strongly feel that this change needs to be done then we can raise a separate issue for that and track them separately.

@muthu-mps , can you please review and confirm ?

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

@rajvi-patel-22
Copy link
Contributor Author

@agithomas, @muthu-mps has approved the PR. Can you please review it so that we can proceed further?

@agithomas
Copy link
Contributor

@agithomas, @muthu-mps has approved the PR. Can you please review it so that we can proceed further?

One approver is enough. You may please proceed with the merge.

@kush-elastic kush-elastic merged commit 9bba8c1 into elastic:main Mar 21, 2023
@elasticmachine
Copy link

Package activemq - 0.7.0 containing this change is available at https://epr.elastic.co/search?package=activemq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Service-Integrations Label for the Service Integrations team v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants