-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NGINX] After 8.6.0, kubernetes pod labels used for condition matching are not dedoted #5099
[NGINX] After 8.6.0, kubernetes pod labels used for condition matching are not dedoted #5099
Conversation
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me. Do you also plan to enhance the provider's docs regarding the dedoting concept?
Yes until now there is no documentation pointing that for autodiscover templates , dedoting was needed for labels. |
Package nginx_ingress_controller - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=nginx_ingress_controller |
What does this PR do?
After 8.6.0, kubernetes pod labels used for condition matching are not dedoted.
PR that introduced this is elastic/elastic-agent#1398
So the
nginx_ingress_controller
integration needs to be updated with the correct defaults for conditions used to match the ingress-nginx pod.Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally