Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Migrate compute metrics dashboard to lens #5038

Conversation

tommyers-elastic
Copy link
Contributor

@tommyers-elastic tommyers-elastic commented Jan 18, 2023

What does this PR do?

Migrates GCP compute metrics dashboard visualizations to lens. Adds top-level datastream filter to improve performance.

Note to reviewers: when migrating the 'Read/Write IO' and "Network sent/received' panels, I noticed that the existing aggregations are based on doc count, not top values of the metric. I thought this was a bit strange. The resulting charts are quite different, as you can see in the screenshots below. One additional change in the new panels, is that I have left the 'Other' groupings in the 'top values' aggs, which can be removed if deemed necessary.

Before:

Screenshot 2023-01-18 at 12 13 40
Screenshot 2023-01-18 at 12 13 46

After:

Screenshot 2023-01-18 at 12 13 55
Screenshot 2023-01-18 at 12 14 02

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Install and validate the new dashboard locally.

How to test this PR locally

cd packages/gcp
elastic-package build .
elastic-package stack up -d --services=package-registry
...

Related issues

Tracked by #5015.

@tommyers-elastic tommyers-elastic added the enhancement New feature or request label Jan 18, 2023
@tommyers-elastic tommyers-elastic requested review from a team as code owners January 18, 2023 12:11
@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2023

⚠️ The sha of the head commit of this PR conflicts with #5032. Mergify cannot evaluate rules on this PR. ⚠️

@elasticmachine
Copy link

elasticmachine commented Jan 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-23T10:52:39.787+0000

  • Duration: 18 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 59
Skipped 0
Total 59

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jan 18, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 89.623% (95/106) 👎 -3.711
Lines 96.0% (1464/1525) 👎 -1.041
Conditionals 100.0% (0/0) 💚

@andrewkroh andrewkroh added the Integration:gcp Google Cloud Platform label Jan 18, 2023
@andrewkroh andrewkroh changed the title Migrate GCP compute metrics dashboard to lens [GCP] Migrate compute metrics dashboard to lens Jan 18, 2023
@endorama
Copy link
Member

I installed the package in this PR but the dashboard does not seem to be updated, I still see the "Before" version. @tommyers-elastic do you have any suggestion? I started from scratch with a 8.6.0 stack started through elastic-package.

Copy link
Member

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the dashboard looks good and works as expected. 2 minor comments:

packages/gcp/kibana/tag/gcp-fleet-managed-default.json Outdated Show resolved Hide resolved
packages/gcp/changelog.yml Outdated Show resolved Hide resolved
@tommyers-elastic tommyers-elastic force-pushed the 5015-migrate-gcp-compute-dashboard-to-lens branch from fb77e54 to b01dbaa Compare January 19, 2023 14:21
Copy link
Contributor

@gpop63 gpop63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the dashboard with data, the data stream filter is applied, seems fine to me!

@tommyers-elastic tommyers-elastic dismissed endorama’s stale review January 30, 2023 14:27

changes are addressed in latest commit

Copy link
Member

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments address, lets get to main!! :shipit:

@botelastic
Copy link

botelastic bot commented Mar 1, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Mar 1, 2023
@botelastic botelastic bot removed the Stalled label Mar 23, 2023
@endorama endorama added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Mar 23, 2023
@endorama endorama merged commit 52fb234 into elastic:main Mar 23, 2023
@elasticmachine
Copy link

Package gcp - 2.19.1 containing this change is available at https://epr.elastic.co/search?package=gcp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants