-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCP] Migrate compute metrics dashboard to lens #5038
[GCP] Migrate compute metrics dashboard to lens #5038
Conversation
|
🌐 Coverage report
|
I installed the package in this PR but the dashboard does not seem to be updated, I still see the "Before" version. @tommyers-elastic do you have any suggestion? I started from scratch with a 8.6.0 stack started through elastic-package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the dashboard looks good and works as expected. 2 minor comments:
- it seems this PR builds upon [GCP] Remove broken input control reference panel and replace with new-style control #5032
- tags (that have been exported through elastic-package) should not be added
fb77e54
to
b01dbaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the dashboard with data, the data stream filter is applied, seems fine to me!
changes are addressed in latest commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments address, lets get to main!!
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Package gcp - 2.19.1 containing this change is available at https://epr.elastic.co/search?package=gcp |
What does this PR do?
Migrates GCP compute metrics dashboard visualizations to lens. Adds top-level datastream filter to improve performance.
Note to reviewers: when migrating the 'Read/Write IO' and "Network sent/received' panels, I noticed that the existing aggregations are based on doc count, not top values of the metric. I thought this was a bit strange. The resulting charts are quite different, as you can see in the screenshots below. One additional change in the new panels, is that I have left the 'Other' groupings in the 'top values' aggs, which can be removed if deemed necessary.
Before:
After:
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Tracked by #5015.