Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suricata] Defensive copy of parameter lists #4731

Merged
merged 4 commits into from
Nov 29, 2022
Merged

[suricata] Defensive copy of parameter lists #4731

merged 4 commits into from
Nov 29, 2022

Conversation

joegallo
Copy link
Contributor

What does this PR do?

Fixes #4723. Adds a defensive copy of the lists that we use from the params map, very much in the style of what was done previously in #3492.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@joegallo
Defensive copy of param lists
980a71c 
Copy list parameters before setting them into the context, rather than
setting them directly -- this avoids leaking a 'static' mutable list
(and the resulting concurrent modification exceptions).
@joegallo
Add an entry to the changelog
5e5768a
@joegallo
Bump the version number in the manifest
bb6cced
@joegallo joegallo added bug Something isn't working, use only for issues Integration:suricata Suricata labels Nov 29, 2022
@joegallo joegallo requested a review from P1llus November 29, 2022 14:29
@joegallo joegallo requested a review from a team as a code owner November 29, 2022 14:29
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 29, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-29T14:48:17.489+0000

  • Duration: 15 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 27
Skipped 0
Total 27

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (5/5) 💚
Classes 100.0% (5/5) 💚
Methods 100.0% (44/44) 💚
Lines 95.94% (827/862) 👍 0.812
Conditionals 100.0% (0/0) 💚

P1llus
P1llus approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to update the link on the changelog and then we merge.

@P1llus P1llus merged commit 2230596 into elastic:main Nov 29, 2022
@joegallo joegallo deleted the suricata-copy-param-lists branch November 29, 2022 15:28
@elasticmachine
Copy link

Package suricata - 2.5.1 containing this change is available at https://epr.elastic.co/search?package=suricata

@masseyke masseyke mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

Assignees
No one assigned
Labels
bug Something isn't working, use only for issues Integration:suricata Suricata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[suricata] don't modify shared mutable param lists
3 participants
@joegallo @elasticmachine @P1llus