Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nats package #413

Merged
merged 20 commits into from
Nov 30, 2020
Merged

Add nats package #413

merged 20 commits into from
Nov 30, 2020

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Nov 24, 2020 •
edited
Loading

What does this PR do?

This PR adds the NATS package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

How to test this PR locally

  1. Manually start Elastic stack and Nats service
  2. Enable NAts integration from Fleet UI
  3. Verify data are populated and both dashboards work.

Related issues

Screenshots

Screenshot 2020-11-25 at 11 23 09

Screenshot 2020-11-25 at 12 22 57

Screenshot 2020-11-25 at 12 23 09

Screenshot 2020-11-25 at 12 24 15

Screenshot 2020-11-25 at 13 45 32

Screenshot 2020-11-25 at 13 47 47

@ChrsMark
Add nats package
50e571b 
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark ChrsMark self-assigned this Nov 24, 2020
@elasticmachine
Copy link

Pinging @elastic/integrations-platforms (Team:Platforms)

@elasticmachine
Copy link

elasticmachine commented Nov 24, 2020 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #413 updated

  • Start Time: 2020-11-30T14:42:18.904+0000

  • Duration: 14 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

@ChrsMark
fixes
9188819 
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark
Add docs
4eac242 
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark
fix docs
15e5436 
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark
format & lint
bc3c25d 
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark
Add ecs fields
77b175f 
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark
Add more ecs fields
34da90c 
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark
fix visualisation queries
44d4df9 
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark
Add events.json
c18bb80 
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark
Update and format
6f7f824 
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark
Add system tests
3030dba 
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark
Add data_stream filters
f1d0811 
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark
Merge remote-tracking branch 'upstream/master' into add_nats_package
d921b48
@ChrsMark ChrsMark mentioned this pull request Nov 26, 2020
Closed
@ChrsMark
wip: Add pipeline test
9481557 
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark
fix pipeline test
c2c1596 
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark ChrsMark changed the title [WIP] Add nats package Add nats package Nov 26, 2020
@ChrsMark
Copy link
Member Author

@elastic/integrations-platforms this one is ready for review!

@mtojek mtojek self-requested a review November 30, 2020 13:34
mtojek
mtojek approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice that there're dashboards available ;) Feel free to merge this and iterate in next pull requests if necessary.

packages/nats/data_stream/connection/manifest.yml
multi: false
required: true
show_user: true
default: 10s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not sure if it's not too often. Maybe 30s for all data streams? Is it according to the migration assessment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap assessment has it like this: https://github.com/elastic/integrations-dev/blob/master/migration/packages/nats.md#datasets, but we can change it in the future if we see it's not realistic.

packages/nats/data_stream/connection/sample_event.json Outdated
"_id": "llFC_3UBsNbKIce5kE5a",
"_version": 1,
"_score": null,
"_source": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in general you can extract the _source content from this JSON document.

@ChrsMark
Small final fixes
47e2032 
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark ChrsMark merged commit 01cace5 into elastic:master Nov 30, 2020
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@ChrsMark
Add nats package (elastic#413)
760f0a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@ChrsMark ChrsMark

Labels
Integration:nats NATS New Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create nats package
4 participants
@ChrsMark @elasticmachine @mtojek @andrewkroh