Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synthetics - fix private locations name for icmp and tcp monitors #3925

Merged

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Aug 1, 2022

Relates to elastic/uptime#475

Please label this PR with one of the following labels, depending on the scope of your change:

  • Bug

What does this PR do?

Adds observer.geo.name when defined, such as for private location monitors.

Testing

  1. Pull down this PR. In the root of the integrations repo, cd packages/synthetics, run elastic-package clean, then elastic-package build.
  2. Once the stack is up, stop kibana using docker desktop management
  3. In packages/synthetics directory, run elastic-package stack up --versions 8.4.0-SNAPSHOT -v
  4. Check out Kibana branch 8.4
  5. Add the following to your local kibana.dev.yml
elasticsearch:
  hosts: ["https://localhost:9200"]
  username: "kibana_system"
  password: "changeme"
xpack.fleet.registryUrl: https://localhost:8080
  1. Run curl -k -u elastic:changeme -X POST "https://localhost:9200/_security/user/kibana_system/_password?pretty" -H 'Content-Type: application/json' -d' { "password" : "changeme" } '
  2. Run eval "$(elastic-package stack shellinit)"
  3. Run export NODE_EXTRA_CA_CERTS=${ELASTIC_PACKAGE_CA_CERT}.
  4. Start your local Kibana. Fleet server and agent should now be configured correctly. You can confirm by visiting the fleet page
  5. Create a synthetics private location
  6. Create an ICMP and TCP monitor for that location
  7. Ensure those monitors' results include the custom location name.

@elasticmachine
Copy link

elasticmachine commented Aug 1, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-01T19:36:55.301+0000

  • Duration: 15 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.175
Classes 100.0% (0/0) 💚 3.175
Methods 33.333% (6/18) 👎 -55.374
Lines 100.0% (0/0) 💚 10.687
Conditionals 100.0% (0/0) 💚

@dominiqueclarke dominiqueclarke added bug Something isn't working, use only for issues v8.4.0 Team:obs-ux-infra_services Label for the Obs UX: Infra & Services team [elastic/obs-ux-infra_services-team] labels Aug 1, 2022
@elasticmachine
Copy link

Pinging @elastic/uptime (Team:Uptime)

@shahzad31 shahzad31 merged commit ada7506 into elastic:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Team:obs-ux-infra_services Label for the Obs UX: Infra & Services team [elastic/obs-ux-infra_services-team] v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants